<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126620/">https://git.reviewboard.kde.org/r/126620/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">clazy-old-style-connect</code> changes can apply. Is it accepted to have c++11-style connects in KF5?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the rest, +1.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 3rd, 2016, 10:09 p.m. CET, Artur Puzio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Artur Puzio.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2016, 10:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kparts
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: QString* being called [-Wclazy-qstring-uneeded-heap-allocations]</code> by changing to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStringLiteral</code>-s.
In <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">plugin.cpp:96</code> I haven't fixed the warnings, becouse <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStringLiteral</code> would give an error. I applied my own optimisation instead.
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Don't call QList::first() on temporary [-Wclazy-detaching-temporary]</code> by changeing to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">at(0)</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Reserve candidate [-Wclazy-reserve-candidates]</code> by adding a simple <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">reserve</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Old Style Connect [-Wclazy-old-style-connect]</code> I had to change all of them by hand, becouse of a bug in clazy that I will be reporting. I wasn't able to change 4 Old Style Connects. (3 in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kreadonlypart.cpp</code>, 1 in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">readwritepart.cpp</code>)
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: KParts::BrowserOpenOrSaveQuestion has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]</code>, by adding <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_DISABLE_COPY</code>, becouse <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">BrowserOpenOrSaveQuestionPrivate</code> isn't copyable
Only warnings that I left are the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">[-Wclazy-function-args-by-ref]</code> warnings, becouse they would involve modifying headers.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Automated tests pass.
Imported note: On my computer I'm runing versions 5.17.0 and it wasn't possible for me to upgrade easly, so I changed the CMakeFiles.txt to compile it. (of course the changed isn't included in this RR)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browserextension.cpp <span style="color: grey">(4b7252c)</span></li>
<li>src/browseropenorsavequestion.h <span style="color: grey">(85dcfa0)</span></li>
<li>src/browseropenorsavequestion.cpp <span style="color: grey">(c1425c1)</span></li>
<li>src/browserrun.cpp <span style="color: grey">(4756511)</span></li>
<li>src/browserrun_p.h <span style="color: grey">(4742598)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(9b0c3c5)</span></li>
<li>src/part.cpp <span style="color: grey">(1657561)</span></li>
<li>src/partmanager.cpp <span style="color: grey">(81bf73f)</span></li>
<li>src/plugin.cpp <span style="color: grey">(97f7d28)</span></li>
<li>src/scriptableextension.cpp <span style="color: grey">(27676bc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126620/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>