<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126392/">https://git.reviewboard.kde.org/r/126392/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit d9e679e4f60d2c21c2d256c1a343a38b2dfa9a6f by Aleix Pol on behalf of Andrey Cygankov to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix some Clazy warnings:
- unneeded heap allocation with QString
- midRef() non-usage
- isEmpty() non-usage</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiling without errors</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/ktexttohtmltest.cpp <span style="color: grey">(81c3fc0)</span></li>
<li>src/lib/io/kbackup.h <span style="color: grey">(ead2de5)</span></li>
<li>src/lib/io/kbackup.cpp <span style="color: grey">(ec8b8b2)</span></li>
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(34b32b7)</span></li>
<li>src/lib/io/kdirwatch_p.h <span style="color: grey">(4483961)</span></li>
<li>src/lib/io/kmessage.cpp <span style="color: grey">(305318c)</span></li>
<li>src/lib/io/kprocess.cpp <span style="color: grey">(1df61c0)</span></li>
<li>src/lib/io/kurlmimedata.cpp <span style="color: grey">(4095ee1)</span></li>
<li>src/lib/kaboutdata.h <span style="color: grey">(0dbd7a0)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(5d9a55e)</span></li>
<li>src/lib/randomness/krandom.cpp <span style="color: grey">(2eb80d2)</span></li>
<li>src/lib/text/kmacroexpander.cpp <span style="color: grey">(0d05ffd)</span></li>
<li>src/lib/text/kstringhandler.cpp <span style="color: grey">(826ddcb)</span></li>
<li>src/lib/text/ktexttohtml.cpp <span style="color: grey">(d58f5c0)</span></li>
<li>src/lib/util/kshell.cpp <span style="color: grey">(11892ce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126392/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>