<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126505/">https://git.reviewboard.kde.org/r/126505/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just one question: Why should a mismatch only be considered when the two have the same length?
Couldn't you show the warning as soon as an actual mismatch is detected, even if that happens before the confirmation password has the same length as the original one?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Example:
Original password is 1234
I type in the second field:
1 -> nothing happens
2 -> nothing happens
4 -> Mismatch error is shown, because no matter what else I type, unless I change the third character in the confirmation, it's definitely a mismatch</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This would be especially important for long passwords that are typed in masked mode, because it would save the user from typing e.g. 10 more characters before being informed about the mistake they made in the second character
Otherwiese it sounds good!</p></pre>
<br />
<p>- Thomas Pfeiffer</p>
<br />
<p>On December 24th, 2015, 5:53 p.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability, Christoph Feck, David Faure, and Thomas Pfeiffer.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2015, 5:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As discussed in RR 125619 and 126426, the password verification field (in a KNewPasswordWidget) should not be marked as "wrong" before the user even started typing the verification password.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My revised approach is the following:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">the first time, no "warning color" is displayed at all. The user types something as password and then something else as verification password.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">If a match occurred (e.g. pwd = 1234 and verification = 1234), we "enable" the warning color. So if the user "breaks" the match (e.g. changing the value in one of the two fields) the warning color will be displayed.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Otherwise, if a mismatch occurred, we also enable the warning color and we show it immediately. A mismatch occurs when the password and the verification password have same length but different content (e.g. pwd = 1234 and verification = 1233).</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Autotests assert what described above. Gif pictures would explain the patch better than 1000 words, but I suck at creating them :(</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/knewpasswordwidgettest.h <span style="color: grey">(43845128adec01aced4353c9f7986b7977829a2a)</span></li>
<li>autotests/knewpasswordwidgettest.cpp <span style="color: grey">(297b88d5f18b9cd37f0d26d94e56f38870756f20)</span></li>
<li>src/knewpasswordwidget.cpp <span style="color: grey">(a1b59454a2c2d7c09ac32acec52d3fffa73f77fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126505/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>