<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126185/">https://git.reviewboard.kde.org/r/126185/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2015, 7:14 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You might want to generate the documentation and look at it (you need the Sphinx documentation tool installed, then you just build extra-cmake-modules, and look in docs/html in the build directory).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In particular, you'll need to add a link file in docs/kde-module.</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On December 16th, 2015, 12:25 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2015, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">templates are very useful as teaching tool in order to make
a minimal application that uses a certain framework.
templates in the KAppTemplate repository will always get forgotten
(plus kapptemplate is not really necessary as they work in kdevelop as well)
An ideal situation would be frameworks having templates in their own repos
with templates of barebone apps using the main framework features.
In order to do that, the cmake stuff needed in order to correctly install
a template needs to be ported to a place avaiable to all frameworks</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">done some templates installed by plasma-framework</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(b7cd34d)</span></li>
<li>kde-modules/KDEPackageAppTemplates.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1a66f56)</span></li>
<li>tests/KDEPackageAppTemplatesTest/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEPackageAppTemplatesTest/run_test.cmake.config <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126185/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>