<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126350/">https://git.reviewboard.kde.org/r/126350/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 14th, 2015, 8:10 p.m. CET, <b>Sergio Martins</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126350/diff/1/?file=422775#file422775line389" style="color: black; font-weight: bold; text-decoration: underline;">src/klocalizedstring.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KLocalizedStringPrivate::translateRaw(const QByteArray &domain,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">389</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qWarning</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">389</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qWarning</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this will break the build with MSVC, it doesn't support QStringLiteral with multi-line literals.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(hint:
export CLAZY_EXTRA_OPTIONS="qstring-uneeded-heap-allocations-msvc-compat"
)</p></pre>
</blockquote>
<p>On December 14th, 2015, 11:16 p.m. CET, <b>Nick Shaforostoff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why QString is used for debug output in the first place?
there is operator<<(const char * s) for latin1 text, which is the case
(i.e. no non-latin symbols are used in the literals)
using strings for debugging output is suboptimal</pre>
</blockquote>
<p>On December 15th, 2015, 8:35 a.m. CET, <b>Artur Puzio</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">look at line 487:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">qWarning</span><span style="color: #666666">()</span> <span style="color: #666666"><<</span> <span style="color: #008000; font-weight: bold">QStringLiteral</span><span style="color: #666666">(</span>
<span style="color: #BA2121">"Plural argument to message {%1} not supplied before conversion."</span><span style="color: #666666">)</span>
<span style="color: #0000FF; font-weight: bold">.arg</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">shortenMessage</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">QString</span><span style="color: #666666">:</span><span style="color: #AA22FF">:fromUtf8</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">text</span><span style="color: #666666">)));</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some of QString-s can by changed to const char *, but in other places they are required.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">qWarning() << "Plural argument to message {" << shortenMessage(QString::fromUtf8(text))<< "} not supplied before conversion.";</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Still, I don't believe it's up to this iteration to fix this one, the code was already like this.
Artur, can you look at the issue pointed out by Sergio?</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On December 14th, 2015, 7:46 p.m. CET, Artur Puzio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Artur Puzio.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2015, 7:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: KuitSetup has dtor, copy-ctor but not copy-assignment [-Wclazy-rule-of-three]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Reserve candidate [-Wclazy-reserve-candidates]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Use QVariant::toFoo() instead of QVariant::value<Foo>() [-Wclazy-variant-sanitizer]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Use midRef() instead [-Wclazy-qstring-ref]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Pass small and trivially-copyable type by value (const class QChar &) [-Wclazy-foreach]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: QString::fromLatin1() being passed a literal [-Wclazy-qstring-uneeded-heap-allocations]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: QString(const char*) being called [-Wclazy-qstring-uneeded-heap-allocations]</code>
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: QString(QLatin1String) being called [-Wclazy-qstring-uneeded-heap-allocations]</code></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Automated tests 1,3 and 4 passing.
Test 2 fails on my system both: after changes and before.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcatalog.cpp <span style="color: grey">(7711e9b)</span></li>
<li>src/klocalizedcontext.cpp <span style="color: grey">(3bc42dd)</span></li>
<li>src/common_helpers.cpp <span style="color: grey">(dad7f84)</span></li>
<li>src/klocalizedstring.cpp <span style="color: grey">(69950d2)</span></li>
<li>src/ktranscript.cpp <span style="color: grey">(04dda66)</span></li>
<li>src/kuitmarkup.h <span style="color: grey">(d110ca3)</span></li>
<li>src/kuitmarkup.cpp <span style="color: grey">(02b891a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126350/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>