<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126339/">https://git.reviewboard.kde.org/r/126339/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated Dez. 14, 2015, 10:37 vorm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there actually is a qsysinfo.h, not sure why I didn't find it in the first place.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This removes the direct kdewin dependency by replacing problematic
function calls (uname, snprintf) with their Qt counterparts.
Some leftover unix header includes removed too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Windows, Linux compiles.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(51fe02a01c8166046d1c6085ec4a5b6e617e1fea)</span></li>
<li>src/ecma/kjs_binding.cpp <span style="color: grey">(5e122f0f0d70e6734565e7ab205d14a92c79d287)</span></li>
<li>src/ecma/kjs_navigator.cpp <span style="color: grey">(2f7be8d11e5af84e08ac640ccbc97f70aeac8abd)</span></li>
<li>src/ecma/kjs_proxy.h <span style="color: grey">(24abd1e1bac0932f8829f02185953142c74aadc8)</span></li>
<li>src/ecma/kjs_proxy.cpp <span style="color: grey">(20430f48fce986ca654c49c5771ad839845f11ab)</span></li>
<li>src/khtml_pagecache.cpp <span style="color: grey">(8e1841f6b0e816dfd8faa76f2191b269c4716011)</span></li>
<li>src/khtml_part.cpp <span style="color: grey">(adbcd800a526e9f8fd92a553e62ee64791872938)</span></li>
<li>src/kmultipart/kmultipart.cpp <span style="color: grey">(1ad3bbb9b6d6a022799d5ef85f426fc9f911d45b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126339/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>