<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126241/">https://git.reviewboard.kde.org/r/126241/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I honestly have some doubt on the approach (but no counter proposal either)
Basically the file kstyle.mm is a <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">copy</em> of the .cpp file, with a couple of lines changed. (which I had to track down by
- downloading the patch
- making an explicit diff of the two files
(which makes reviewing quite difficult/useless)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The mm file has the name, but different extension, and is compiled only for OSX
That means that any future fix (by me, or others) applied to one on a different platform will either
- not be ported to the other platform
- be ported blindly without testing (I don't even know how to compile mm on my linux box)
Is this really what we want to do ? </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course one could also add a common parent class to both the linux and osx implementation, that makes 99% of the job (some KStyleBase class),
but then, wont that break binary compatibility badly for all widget styles that inherits these ? (oxygen, breeze)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Finally, the changes applied here only work for kstyle derived styles (oxygen, breeze), and not the QStyle based one. (QtCurve ?)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">... not convinced. (but not strong objection either)</p></pre>
<br />
<p>- Hugo Pereira Da Costa</p>
<br />
<p>On December 4th, 2015, 12:27 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks and Hugo Pereira Da Costa.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2015, 12:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a split-off from RR https://git.reviewboard.kde.org/r/126198/, as suggested there.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The proposed change (which is a work in progress) contains a few modifications mirroring those proposed for the KdePlatformTheme plugin, aiming to adapt the library to Mac OS X.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These modifications should probably be implemented by subclassing KStyle rather than duplicating all code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have been focussing on the platform theme modifications, without really looking into the extent to which KStyle is used or potentially useful on OS X. A separate RR should support discussion about that more easily.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would it for instance be possible to use KStyle to create a Qt <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">style</em> plugin that does nothing more than extending the native theme/style with support for KDE's font roles/types, colour palettes and icon themes? This could be preferable for users or developers who are not interested in providing a consistent cross-platform look (which presumable requires a platform <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">theme</em>) and/or who do not want to depend on a theme that makes explicit use of a private Qt API (cf. <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KdeMacTheme</code> in the RR above).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds on OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 ; "source" modifications are tested in the platform theme.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kstyle/CMakeLists.txt <span style="color: grey">(bc26667)</span></li>
<li>src/kstyle/kstyle.mm <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126241/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>