<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125869/">https://git.reviewboard.kde.org/r/125869/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2015, 9:47 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How does this work without modifying KProtocolInfoPrivate::KProtocolInfoPrivate?</p></pre>
</blockquote>
<p>On November 4th, 2015, 7:39 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You mean the JSON stuff? That was implemented in https://git.reviewboard.kde.org/r/125830/
For the http slave, that already works nicely, but we missed that "ExtraNames" as used by other slaves need i18n care.</p></pre>
</blockquote>
<p>On November 4th, 2015, 10:58 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i see, i did not see that there's two almost copied KProtocolInfoPrivate::KProtocolInfoPrivate implementations</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So the json magic stuff (you can see ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for Description and Name inside KPlugin, someone would need to update createjsoncontext.py and filljsonfrompo.py so they also take into account ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code from 125830 extract the correct translation from the json.</p></pre>
</blockquote>
<p>On November 4th, 2015, 11:23 p.m. UTC, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reading the translated string can be done using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KPluginMetaData::readTranslatedString()</code></p></pre>
</blockquote>
<p>On November 5th, 2015, 6:49 a.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, Ok, can take a look at that scripts. Will it be a problem that the ExtraNames are a stringlist or is that fine?</p></pre>
</blockquote>
<p>On November 5th, 2015, 9:43 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You'll have to take care of serializing and unserializing the list, ideally using a well known marker like ; or similar. The scripts are at https://websvn.kde.org/trunk/l10n-kf5/scripts/</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, ok, started to take a look at that again ;=) Is there actually any way to get all entries out of KConfig for all locales in the .ini? Atm I struggle a bit with the fact that the localized keys are hidden from any keys() accessor I can get from the outside.</p></pre>
<br />
<p>- Christoph</p>
<br />
<p>On November 1st, 2015, 6:13 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2015, 6:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Convert all io slave .protocol data to json and embed it.
Allows easier deployment of the slaves.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests still work (one needed patching, as the exec line contains now the full path).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/CMakeLists.txt <span style="color: grey">(76a8e28)</span></li>
<li>src/ioslaves/help/main_ghelp.cpp <span style="color: grey">(59c8558)</span></li>
<li>src/ioslaves/help/main.cpp <span style="color: grey">(9939196)</span></li>
<li>src/ioslaves/help/help.protocol <span style="color: grey">(1deefe5)</span></li>
<li>src/ioslaves/help/help.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/ghelp.protocol <span style="color: grey">(d2a642a)</span></li>
<li>src/ioslaves/help/ghelp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/CMakeLists.txt <span style="color: grey">(867b59d)</span></li>
<li>src/ioslaves/ftp/ftp.protocol <span style="color: grey">(4c5f80c)</span></li>
<li>src/ioslaves/ftp/ftp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(382723a)</span></li>
<li>src/ioslaves/ftp/CMakeLists.txt <span style="color: grey">(04f5600)</span></li>
<li>src/ioslaves/file/file.protocol <span style="color: grey">(523c0f5)</span></li>
<li>src/ioslaves/file/file.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/file/file.cpp <span style="color: grey">(5ef1587)</span></li>
<li>src/ioslaves/file/CMakeLists.txt <span style="color: grey">(cb85cfb)</span></li>
<li>autotests/kprotocolinfotest.cpp <span style="color: grey">(fa3ad38)</span></li>
<li>src/ioslaves/http/http.protocol <span style="color: grey">(49e5dc5)</span></li>
<li>src/ioslaves/http/https.protocol <span style="color: grey">(c15d06f)</span></li>
<li>src/ioslaves/http/webdav.protocol <span style="color: grey">(05c977a)</span></li>
<li>src/ioslaves/http/webdavs.protocol <span style="color: grey">(d5e4b2f)</span></li>
<li>src/ioslaves/trash/CMakeLists.txt <span style="color: grey">(05161cd)</span></li>
<li>src/ioslaves/trash/kio_trash.cpp <span style="color: grey">(cb23169)</span></li>
<li>src/ioslaves/trash/trash.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/trash/trash.protocol <span style="color: grey">(7430575)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125869/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>