<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126038/">https://git.reviewboard.kde.org/r/126038/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2015, 4:12 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did the same in https://git.reviewboard.kde.org/r/125869/ but I still need to fix the i18n issue, first :/</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ahh, indeed you did.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should I abandon this? or do I 'add' it to yours? somehow.. I'm new to reviewboard.</p></pre>
<br />
<p>- Andrew</p>
<br />
<p>On November 12th, 2015, 12:59 p.m. UTC, Andrew McCann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Andrew McCann.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2015, 12:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add protocol info to KIO plugin metadata. This is necessary to get KDevelop to work on OSX in an app bundle.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This continues work done by Christoph Cullmann in https://git.reviewboard.kde.org/r/125830/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Followed the same pattern as the aforementioned diff.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">protocol.json files were generated using the protocoltojson utility.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this patch applied, my development version of kdevelop on OSX was able to find:
(logging statements were added by me, but not in this diff)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">{ Found Plugin path "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/file.so"
protocol contains "file"
}
{ Found Plugin path "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/ftp.so"
protocol contains "ftp"
}
{ Found Plugin path "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/ghelp.so"
protocol contains "ghelp"
}
{ Found Plugin path "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/help.so"
protocol contains "help"
}
{ Found Plugin path "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/http.so"
protocol contains "http"
protocol contains "https"
protocol contains "webdav"
protocol contains "webdavs"
}
{ Found Plugin path "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/trash.so"
protocol contains "trash"
}
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/file/file.cpp <span style="color: grey">(381e4885bf0e78ceb4b06f1f1657ad4068923a84)</span></li>
<li>src/ioslaves/file/file.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(2179179e966d97ce24784292ef67812fa1d3361d)</span></li>
<li>src/ioslaves/ftp/ftp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/ghelp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/help.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/help/main.cpp <span style="color: grey">(9939196b4fc4aefd52c2c13717609181429fe891)</span></li>
<li>src/ioslaves/help/main_ghelp.cpp <span style="color: grey">(59c85587af5edf767261a6b3ca66e6f37efecd29)</span></li>
<li>src/ioslaves/trash/kio_trash.cpp <span style="color: grey">(81cc0361d22606f54d31e6ce743cd5fe818a4701)</span></li>
<li>src/ioslaves/trash/kio_trash_win.cpp <span style="color: grey">(9dd857f3dd9aebaef9e8d9e5adfc30adb0c1ae6b)</span></li>
<li>src/ioslaves/trash/trash.json <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>