<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125951/">https://git.reviewboard.kde.org/r/125951/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2015, 8:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restructured things a bit
* it now ensures that the applet config is not actually loading the plugins, it operates only on the metadata
* the list of enabled plugins is now stored per applet in plasmoid.configuration.enabledCalendarPlugins (this is the applet code though so that's another patch)
Enabling and disabling the plugins now work correctly including adding/removing the events from the calendar.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is also made a QML singleton that will be used for the applet
config view where it will add the plugin configs once we add that
possibility.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The same instance is then set to the DaysModel from QML.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship it)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Calendar events are still correctly displayed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: grey">(f698934f850ef3a917b9611c9f9a40c369b23f6c)</span></li>
<li>src/declarativeimports/calendar/eventpluginsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/calendar/daysmodel.h <span style="color: grey">(a5bdac98627f7efa76bd4afd239469b53e06690b)</span></li>
<li>src/declarativeimports/calendar/CMakeLists.txt <span style="color: grey">(40ead911ad5208cae5dbe5333d227f9f8a0d9154)</span></li>
<li>src/declarativeimports/calendar/calendarplugin.cpp <span style="color: grey">(bafe80cf7520a08312abfd1dbd6d4648a6710175)</span></li>
<li>src/declarativeimports/calendar/eventpluginsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: grey">(2d059a8e8636565adbe52811e602fff37a5eb157)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125951/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>