<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125928/">https://git.reviewboard.kde.org/r/125928/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On November 3rd, 2015, 8:24 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus, Rex Dieter, and Harald Sitter.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2015, 8:24 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=353642">353642</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This solves the conflict with kde-baseapps 15.08.x, and simplifies deployment
on Win/Mac.
BUG: 353642
Change-Id: Id4f9e364ceeea6b1b93910aa100ff22ce3fd76a7</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unittest (./knewfilemenutest)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/new_file_templates/templates.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/knewfilemenutest.cpp <span style="color: grey">(968e16e9e8c5d0680c1e6e00af1403f3f5d9976f)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(27b0f2b0e86a0087d343226e8db056109b3cd5ab)</span></li>
<li>src/filewidgets/CMakeLists.txt <span style="color: grey">(6ec254971055d1d1ecf5cf7a6d4637b82a52c27d)</span></li>
<li>src/filewidgets/knewfilemenu.cpp <span style="color: grey">(577206dfa9c89c4db4750f1880547bfb9b6214e7)</span></li>
<li>src/new_file_templates/CMakeLists.txt <span style="color: grey">(0684b1871b35757ebe59c71cff01104bc388bb0f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125928/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>