<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125863/">https://git.reviewboard.kde.org/r/125863/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 30th, 2015, 7:34 p.m. UTC, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how can I debug to ensure this is the case and not a local issue?</p></pre>
</blockquote>
<p>On October 30th, 2015, 7:37 p.m. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Broke in what way? Did you try if it works without this commit?</p></pre>
</blockquote>
<p>On October 30th, 2015, 7:42 p.m. UTC, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I just reverted it and wheel scrolls again.
Broken as in, there is no wheel scrolling in (tested):</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Kate</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Konversation</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Kontact</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But works in:
- Dolphin</p></pre>
</blockquote>
<p>On October 30th, 2015, 7:47 p.m. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It shouldn't break it, unless you have set 0 wheel scroll lines in mouse kcm. In the worst case, it should just ignore that value from kcm and use default 3 lines (but that is what this should be actually fixing).</p></pre>
</blockquote>
<p>On October 30th, 2015, 8:31 p.m. UTC, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FYI, it's set to 3 lines there.</p></pre>
</blockquote>
<p>On October 30th, 2015, 8:42 p.m. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, so can you add qDebug() << "wheelscrolllines" << m_hints[QPlatformTheme::WheelScrollLines]; after it is fetched from config and check it picks the correct value? (line 110 and 337 in khintssettings.cpp)
Also can you test if changing the wheel scroll lines value in mouse kcm and applying it fixes scrolling for running applications?</p></pre>
</blockquote>
<p>On October 30th, 2015, 8:47 p.m. UTC, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before adjusting config in the mouse KCM:
```
kate
wheelscrolllines at line 110 QVariant(int, 0)
0x13dda40 void QWindowPrivate::setTopLevelScreen(QScreen<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13ddf20 void QWindowPrivate::setTopLevelScreen(QScreen</em>, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13de8b0 void QWindowPrivate::setTopLevelScreen(QScreen<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13df0a0 void QWindowPrivate::setTopLevelScreen(QScreen</em>, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13e2150 void QWindowPrivate::setTopLevelScreen(QScreen<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window.
0x145e790 void QWindowPrivate::setTopLevelScreen(QScreen</em>, bool) ( QScreen(0x977880) ): Attempt to set a screen on a child window.
wheelscrolllines at 338 QVariant(int, 0)
````</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After changing config, scrolling works again (need an application restart).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://git.reviewboard.kde.org/r/125884/</p></pre>
<br />
<p>- David</p>
<br />
<p>On October 29th, 2015, 7:01 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2015, 7:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=291144">291144</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use platform theme hint instead of manually using QApplication::setWheelScrollLines</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt 5.5 apps now correctly scroll by the value set in mouse kcm</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/khintssettings.cpp <span style="color: grey">(6e8313d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125863/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>