<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125833/">https://git.reviewboard.kde.org/r/125833/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- David Faure</p>


<br />
<p>On October 28th, 2015, 7:32 a.m. UTC, Laurent Montel wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Matthew Dawson.</div>
<div>By Laurent Montel.</div>


<p style="color: grey;"><i>Updated Oct. 28, 2015, 7:32 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use QStringLiteral in generated code.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All tests are ok.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kconfig_compiler/test1.cpp.ref <span style="color: grey">(dcb3ffc)</span></li>

 <li>autotests/kconfig_compiler/test10.cpp.ref <span style="color: grey">(f067cc6)</span></li>

 <li>autotests/kconfig_compiler/test11.cpp.ref <span style="color: grey">(1e6ff9e)</span></li>

 <li>autotests/kconfig_compiler/test11a.cpp.ref <span style="color: grey">(9165661)</span></li>

 <li>autotests/kconfig_compiler/test12.cpp.ref <span style="color: grey">(e1cd01a)</span></li>

 <li>autotests/kconfig_compiler/test13.cpp.ref <span style="color: grey">(4eac103)</span></li>

 <li>autotests/kconfig_compiler/test2.cpp.ref <span style="color: grey">(e99eb7c)</span></li>

 <li>autotests/kconfig_compiler/test3.cpp.ref <span style="color: grey">(1ac9525)</span></li>

 <li>autotests/kconfig_compiler/test3a.cpp.ref <span style="color: grey">(dc72171)</span></li>

 <li>autotests/kconfig_compiler/test4.cpp.ref <span style="color: grey">(2199c16)</span></li>

 <li>autotests/kconfig_compiler/test5.cpp.ref <span style="color: grey">(323c1ee)</span></li>

 <li>autotests/kconfig_compiler/test6.cpp.ref <span style="color: grey">(629d828)</span></li>

 <li>autotests/kconfig_compiler/test7.cpp.ref <span style="color: grey">(f506b09)</span></li>

 <li>autotests/kconfig_compiler/test8a.cpp.ref <span style="color: grey">(00d4d02)</span></li>

 <li>autotests/kconfig_compiler/test8b.cpp.ref <span style="color: grey">(8890815)</span></li>

 <li>autotests/kconfig_compiler/test9.cpp.ref <span style="color: grey">(bc65f43)</span></li>

 <li>autotests/kconfig_compiler/test_dpointer.cpp.ref <span style="color: grey">(7933bfb)</span></li>

 <li>autotests/kconfig_compiler/test_qdebugcategory.cpp.ref <span style="color: grey">(f2eea33)</span></li>

 <li>autotests/kconfig_compiler/test_signal.cpp.ref <span style="color: grey">(e959571)</span></li>

 <li>autotests/kconfig_compiler/test_translation_kde.cpp.ref <span style="color: grey">(5c11133)</span></li>

 <li>autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref <span style="color: grey">(66fc4cb)</span></li>

 <li>autotests/kconfig_compiler/test_translation_qt.cpp.ref <span style="color: grey">(f5ae727)</span></li>

 <li>src/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(600d67a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125833/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>