<div dir="ltr">Thanks for your notice. I'l do it.</div><div class="gmail_extra"><br><div class="gmail_quote">2015-10-29 17:33 GMT+09:00 David Faure <span dir="ltr"><<a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thursday 22 October 2015 00:08:55 Takahiro Hashimoto wrote:<br>
> Git commit 1c3f42afe17cc090372eaf45647d71495de12c19 by Takahiro Hashimoto.<br>
> Committed on 22/10/2015 at 00:03.<br>
> Pushed by hashimoto into branch 'master'.<br>
><br>
> fix ciritical regression for QuickViewSharedEngine by commit 3792923639b1c480fd622f7d4d31f6f888c925b9<br>
><br>
> view's item is not set if item's geometry is set by manual.<br>
<br>
This looks like it broke the kdeclarative unittests, please investigate.<br>
<br>
00:11:04 2/2 Test #2: quickviewsharedengine ............***Failed    1.73 sec<br>
00:11:04 ********* Start testing of QuickViewSharedEngineTest *********<br>
00:11:04 Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 4.9.2)<br>
00:11:04 PASS   : QuickViewSharedEngineTest::initTestCase()<br>
00:11:04 QWARN  : QuickViewSharedEngineTest::resizemodeitem() bbb QSize(300, 300)<br>
00:11:04 QWARN  : QuickViewSharedEngineTest::resizemodeitem() ccc QSize(300, 300)<br>
00:11:04 FAIL!  : QuickViewSharedEngineTest::resizemodeitem() Compared values are not the same<br>
00:11:04    Actual   (view->initialSize()): QSize(0x0)<br>
00:11:04    Expected (QSize(200, 200))    : QSize(200x200)<br>
00:11:04    Loc: [/home/jenkins/builds/kdeclarative/kf5-qt5/autotests/quickviewsharedengine.cpp(175)]<br>
00:11:04 PASS   : QuickViewSharedEngineTest::errors()<br>
00:11:04 PASS   : QuickViewSharedEngineTest::engine()<br>
00:11:04 PASS   : QuickViewSharedEngineTest::cleanupTestCase()<br>
00:11:04 Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted<br>
00:11:04 ********* Finished testing of QuickViewSharedEngineTest *********<br>
<br>
<a href="https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/changes" rel="noreferrer" target="_blank">https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/changes</a><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
David Faure, <a href="mailto:faure@kde.org">faure@kde.org</a>, <a href="http://www.davidfaure.fr" rel="noreferrer" target="_blank">http://www.davidfaure.fr</a><br>
Working on KDE Frameworks 5<br>
<br>
</font></span></blockquote></div><br></div>