<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125797/">https://git.reviewboard.kde.org/r/125797/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Christoph Cullmann.</div>


<p style="color: grey;"><i>Updated Oct. 26, 2015, 4:50 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Proper namespacing:

{
    "KDE-KIO-Protocols": {
        "http": {
....

}</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Application to convert multiple .protocol files into on json map.
If this is acceptable my next steps would be:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) use this, to generate json files and embedded them in io slaves
2) extend the protocol factory to search in the embedded files</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That would make the protocol factory parts of: https://git.reviewboard.kde.org/r/125778/ not needed.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Feed in http slave files: </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">./protocoltojson -o http.json /local/cullmann/kf5/src/frameworks/kio/src/ioslaves/http/*.protocol</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We get mapping:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">{
    "http": {
        "Class": ":internet",
        "Icon": "text-html",
        "X-DocPath": "kioslave5/http/index.html",
        "defaultMimetype": "application/octet-stream",
        "deleting": true,
        "determineMimetypeFromExtension": false,
        "exec": "kf5/kio/http",
        "input": "none",
        "maxInstances": 20,
        "maxInstancesPerHost": 5,
        "output": "filesystem",
        "protocol": "http",
        "reading": true,
        "writing": true
    },
    "https": {
        "Class": ":internet",
        "Icon": "text-html",
        "X-DocPath": "kioslave5/http/index.html",
        "config": "http",
        "defaultMimetype": "application/octet-stream",
        "deleting": true,
        "determineMimetypeFromExtension": false,
        "exec": "kf5/kio/http",
        "input": "none",
        "maxInstances": 20,
        "maxInstancesPerHost": 5,
        "output": "filesystem",
        "protocol": "https",
        "reading": true,
        "writing": true
    },
    "webdav": {
        "Class": ":internet",
        "Icon": "folder-remote",
        "X-DocPath": "kioslave5/webdav/index.html",
        "defaultMimetype": "application/octet-stream",
        "deleteRecursive": true,
        "deleting": true,
        "determineMimetypeFromExtension": false,
        "exec": "kf5/kio/http",
        "input": "none",
        "listing": [
            "Name",
            "Type",
            "Size",
            "Date",
            "AccessDate",
            "Access"
        ],
        "makedir": true,
        "maxInstances": 20,
        "maxInstancesPerHost": 5,
        "moving": true,
        "output": "filesystem",
        "protocol": "webdav",
        "reading": true,
        "writing": true
    },
    "webdavs": {
        "Class": ":internet",
        "Icon": "folder-remote",
        "X-DocPath": "kioslave5/webdav/index.html",
        "config": "webdav",
        "defaultMimetype": "application/octet-stream",
        "deleteRecursive": true,
        "deleting": true,
        "determineMimetypeFromExtension": false,
        "exec": "kf5/kio/http",
        "input": "none",
        "listing": [
            "Name",
            "Type",
            "Size",
            "Date",
            "AccessDate",
            "Access"
        ],
        "makedir": true,
        "maxInstances": 20,
        "maxInstancesPerHost": 5,
        "moving": true,
        "output": "filesystem",
        "protocol": "webdavs",
        "reading": true,
        "writing": true
    }
}</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(f65ad8e)</span></li>

 <li>src/protocoltojson/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/protocoltojson/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125797/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>