<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125736/">https://git.reviewboard.kde.org/r/125736/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 21st, 2015, 4:49 p.m. CEST, <b>Boudhayan Gupta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125736/diff/3/?file=412105#file412105line26" style="color: black; font-weight: bold; text-decoration: underline;">src/platforms/xcb/kwindoweffects_x11.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class KWindowEffectsPrivateX11 : public KWindowEffectsPrivate</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="nl">KWindowEffectsPrivateX11</span> <span class="p">:</span> <span class="n">public</span> <span class="n">KWindowEffectsPrivate</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="nl">KWindowEffectsPrivateX11</span> <span class="p">:</span> <span class="n">public</span> <span class="n">KWindowEffectsPrivate</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">public</span></span><span class="hl"> </span><span class="n"><span class="hl">KWindowEffectsSkipCloseAnimation</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This was my idea, which sitter also liked and is used in Phonon. The idea is that every individual added feature has its own class which is MI-ed with the core class, that way plugins can choose to implement only the extra features they want.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For example if I add feature A in class 1, then feature B in class 2, but a plugin only wants to implement feature B without implementing feature A, they can't if you do what you're asking.</p></pre>
</blockquote>
<p>On October 21st, 2015, 4:53 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I see what you mean. But that could also be achieved with default implementation instead of pure virtuals. And I do see a problem with that approach: what if you want to add another method one day to e.g. enable close animation again? Then you need to extend KWindowEffectsSkipCloseAnimation in exactly the same way as I proposed originally.</p></pre>
</blockquote>
<p>On October 21st, 2015, 4:59 p.m. CEST, <b>Boudhayan Gupta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Then I add a KWindowEffectsEnableCloseAnimation extension.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is why I put the extensions in another header. kwindoweffects_p.h is going to get very ugly very fast if I keep adding micro-features - let's confine the ugliness to this one place.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you go the chain of inheritence way, it'll end up like this one day:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://quickgit.kde.org/?p=phonon.git&a=blob&h=6b5d878ec9e6e605557b5de12c179d6ac3d5daf8&f=phonon%2Faudiooutputinterface.h&o=plain</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">right, I see your point. Even if I consider it as unlikely that we ever get to a two digit number (based on history of the development of KWindowEffects) ;-)
Then please use a "_p.h" naming. And it also needs to be installed through CMake. Otherwise we cannot use it from kwayland-integration.</pre>
<br />
<p>- Martin</p>
<br />
<p>On October 21st, 2015, 1:55 p.m. CEST, Boudhayan Gupta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Gräßlin.</div>
<div>By Boudhayan Gupta.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2015, 1:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds a Skip Window Close Animation effect to KWindowEffects, with an implementation for X11.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Binary compatibility with older plugins is <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</strong> preserved. I welcome comments on how exactly to do this - creating a new base class (KWindowEffectsPrivate2 based on KWindowEffectsPrivate and basing the plugins off that sounds kind of complicated). Maybe we can just drop internal ABI compatibility and update kwayland-integration to implement the new method too?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">make test succeeds with the new plugin installed</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">make test succeeds on all tests in the kwindoweffects test except the skipCloseAnimation unit with the old plugin installed. skipCloseAnimation segfaults.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kwindoweffectstest.cpp <span style="color: grey">(0e83bdc)</span></li>
<li>src/kwindoweffects.h <span style="color: grey">(bf0ea1e)</span></li>
<li>src/kwindoweffects.cpp <span style="color: grey">(0c6600f)</span></li>
<li>src/kwindoweffects_dummy.cpp <span style="color: grey">(65924ae)</span></li>
<li>src/kwindoweffects_dummy_p.h <span style="color: grey">(2beabdd)</span></li>
<li>src/kwindoweffects_extensions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platforms/xcb/atoms_p.h <span style="color: grey">(b5a6e7e)</span></li>
<li>src/platforms/xcb/kwindoweffects.cpp <span style="color: grey">(c8da6d2)</span></li>
<li>src/platforms/xcb/kwindoweffects_x11.h <span style="color: grey">(c240ddf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125736/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>