<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125262/">https://git.reviewboard.kde.org/r/125262/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Sebastian Kügler.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2015, 10:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit e3b1d023dcf2c10f5b4feb4eb1973bcc0fbdb954 by Alex Richardson to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Parse ServiceType files when reading .desktop files</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove lots of duplicated code for desktop{tojson,fileparser}.cpp</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only reason these were copy-pasted are minor differences in the
output which is now fixed by using qInstallMessageHandler and the
ability to generate JSON compatible with the first published version
of desktoptojson (which is hopefully no longer used and can be removed
soon)</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QCommandLineParser uses -v for --version so just use --verbose</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise the whole QCommandlineOption is ignored and there is no way
to enable verbose mode</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">desktopparser: Use more categorized logging</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">desktopparser: Allow passing relative paths to service type files</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add KPluginMetaData::fromDesktopFile()</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This function allows specifying a list of service type files to be
parsed when loading the .desktop file.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">desktopparser: Improve warning messages and add new unit test</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The new test checks how the desktop parser handles service type files
with invalid property definitions</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">desktopparser: Fix parsing of double and bool values</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QString::compare returns 0 on equal and make sure that we don't assign
the parsed double to an integer local variable</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add another unit test for desktop parsing with service types</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test that all supported types are converted correctly</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Allow setting service types in kcoreaddons_desktop_to_json()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added some unit test and they pass</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5CoreAddonsMacros.cmake <span style="color: grey">(acfcaa3069991395d83923bcc30cd08f231c30eb)</span></li>
<li>autotests/data/servicetypes/bad-groups-input.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/servicetypes/bad-groups-servicetype.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/servicetypes/example-input.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/servicetypes/example-servicetype.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/servicetypes/fake-kdevelopplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/desktoptojsontest.cpp <span style="color: grey">(63ba2bee10de77ae6c0697cb654defa67d069f65)</span></li>
<li>autotests/kpluginmetadatatest.cpp <span style="color: grey">(82ec06a91005ffd2c8e50d7a641706c6c7beac6b)</span></li>
<li>src/desktoptojson/CMakeLists.txt <span style="color: grey">(94a199d8fa44a21b15e24c2e4f42551adada8f72)</span></li>
<li>src/desktoptojson/desktoptojson.h <span style="color: grey">(bfa38b0f5ddd0581ad176d854614bc9c80dd139a)</span></li>
<li>src/desktoptojson/desktoptojson.cpp <span style="color: grey">(f07de309a667aaa017a22f761222f2b5f6694ccb)</span></li>
<li>src/desktoptojson/main.cpp <span style="color: grey">(9bac8ff55d005d1944c04f557aa9601de2b0ca15)</span></li>
<li>src/lib/plugin/desktopfileparser.cpp <span style="color: grey">(0f71ead0e83270d757179ad233982beadb6c9806)</span></li>
<li>src/lib/plugin/desktopfileparser_p.h <span style="color: grey">(767146e691a9b6c9827c5b7bcd9b73c98ff868e3)</span></li>
<li>src/lib/plugin/kpluginmetadata.h <span style="color: grey">(59b6a9db0811d24c9ad8a3e86212ea50b9cd95ce)</span></li>
<li>src/lib/plugin/kpluginmetadata.cpp <span style="color: grey">(f7942b1aef3f165c0fab2a0cb4422422342e5f8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125262/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>