<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125484/">https://git.reviewboard.kde.org/r/125484/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 2nd, 2015, 8:43 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks ok to me, except that KHistoryComboBox also adds such a menu item to the KLineEdit popup. Can you check if it has it twice now? I would expect so. In that case you could remove the action+slot from KHistoryComboBox then? (compare the slots to be sure it's the same logic).</p></pre>
</blockquote>
<p>On October 3rd, 2015, 3:12 p.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's not totally the same logic</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it will clear the combobox + textline too.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I will add a test application for khistorycombobox soon to test it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">void KHistoryComboBox::clearHistory()
{
const QString temp = currentText();
KComboBox::clear();
if (useCompletion()) {
completionObject()->clear();
}
setEditText(temp);
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">void KHistoryComboBoxPrivate::_k_addContextMenuItems(QMenu <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">menu)
{
Q_Q(KHistoryComboBox);
if (menu) {
menu->addSeparator();
QAction </em>clearHistory = menu->addAction(QIcon::fromTheme("edit-clear-history"),
KHistoryComboBox::tr("Clear &History"),
q, SLOT(_k_clear()));
if (!q->count()) {
clearHistory->setEnabled(false);
}
}
}</p></pre>
</blockquote>
<p>On October 3rd, 2015, 3:18 p.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is a test in source "kcompletionuitest"
so not necessary to create a new test.</p></pre>
</blockquote>
<p>On October 3rd, 2015, 3:20 p.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">indeed it create 2 "clear history"
I will investigate how to replace it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This doesn't clear the text line (QLineEdit), on the contrary, it saves and restores its contents.
But indeed, when we have a combo, there are the combo items to clear as well, not just the completion.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So I think KLineEdit needs to emit a signal when its action is triggered, so that KHistoryComboBox can add "clearing the combo".
(I guess not KComboBox, which could have application-provided items, unrelated to completion/history)</p></pre>
<br />
<p>- David</p>
<br />
<p>On October 2nd, 2015, 8:14 p.m. UTC, Laurent Montel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Laurent Montel.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2015, 8:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In a application we can't remove history until we close it. It can be problematic when we add a critical word as password etc.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested in kdepim from long time ago.
Tested in klineedittest apps.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klineedit.h <span style="color: grey">(59cec4e)</span></li>
<li>src/klineedit.cpp <span style="color: grey">(37c079d)</span></li>
<li>src/klineedit_p.h <span style="color: grey">(c7b63c6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125484/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>