<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124983/">https://git.reviewboard.kde.org/r/124983/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2015, 4:37 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the comments, David, Luigi and Albert!
I've removed all devices, as suggested by David (we can actually also remove the "Link to Device" menu from KNewFileMenu then, but I'll do that in a second patch once the present change is in master).
If there are any further suggestions for improvement, please let me know, such that they can be included when I push this to master after the next KF5 release.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349654">349654</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently, the standard entries of KNewFileMenu are in lib/konq in the kde-baseapps repository, which has no released KF5 version. Therefore, the menu is empty now for most users. Those who build their KDE software with kdesrc-build, whose standard KF5 config includes kde-baseapps, might now have noticed the issue yet.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch simply moves the relevant files to kio. Some questions that might be worth discussing:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Is kio considered the correct place for this, or should the files be in kio-extras?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Are all the menu entries still relevant, or should some be removed or modified?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Is it OK to move the desktop files including translations, or will this confuse the i18n infrastructure that our brave translators use?</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I disabled the build of kde-baseapps locally. The "Create New..." menu was empty then, but it is populated again with this patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(a1d644d)</span></li>
<li>src/new_file_templates/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/Directory.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/HTMLFile.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/HTMLFile.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/Program.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/TextFile.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/TextFile.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/URL.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkPath.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkProgram.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkURL.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124983/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>