<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124983/">https://git.reviewboard.kde.org/r/124983/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On settembre 21st, 2015, 9:38 a.m. CEST, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, thanks for that. Some feedback (sorry for the delay)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) kio is fine. kio-extras exists because some things in there bring additional dependencies.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) I think we should remove all devices. Not just floppy ;) but in general, the way to use devices in KDE is no longer to create a desktop file for them (for explicit mount/unmount), but rather to use the GUI provided on top of Solid (in the systray; in dolphin; etc). I wonder if anyone still uses device desktop files? AFAIU you need an entry in fstab to be able to mount anything as a user, and the places model in dolphin shows everything from fstab...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">3) No confusion will happen, but the translations will have to be redone, unless some brave soul performs the necessary operations on the l10n module.
You could ask Luigi Toscano (iirc). In any case, commit this in the 2 weeks after a KF release rather than in the two weeks before the next one,
to give translators time to catch up.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We can merge the translations of the desktop files from kde-baseapps. Only question mark, the license: the translations for these messages are currently merged with the translations of all .desktop files from kde-baseapps. But given that they are translations of messages from lib/konq, which seems to be LGPL, it should be fine, right?</p></pre>
<br />
<p>- Luigi</p>
<br />
<p>On agosto 29th, 2015, 8:23 p.m. CEST, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Ago. 29, 2015, 8:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349654">349654</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently, the standard entries of KNewFileMenu are in lib/konq in the kde-baseapps repository, which has no released KF5 version. Therefore, the menu is empty now for most users. Those who build their KDE software with kdesrc-build, whose standard KF5 config includes kde-baseapps, might now have noticed the issue yet.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch simply moves the relevant files to kio. Some questions that might be worth discussing:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Is kio considered the correct place for this, or should the files be in kio-extras?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Are all the menu entries still relevant, or should some be removed or modified?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Is it OK to move the desktop files including translations, or will this confuse the i18n infrastructure that our brave translators use?</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I disabled the build of kde-baseapps locally. The "Create New..." menu was empty then, but it is populated again with this patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(a1d644d)</span></li>
<li>src/new_file_templates/CAMERA-Device.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/CDROM-Device.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/CDWRITER-Device.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/DVDROM-Device.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/Directory.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/Floppy.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/HD.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/HTMLFile.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/HTMLFile.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/MO-Device.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/NFS.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/Program.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/TextFile.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/TextFile.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/URL.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/ZIP-Device.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkCAMERA.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkCDROM.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkCDWRITER.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkDVDROM.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkFloppy.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkHD.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkMO.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkNFS.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkPath.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkProgram.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkURL.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/new_file_templates/linkZIP.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124983/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>