<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125314/">https://git.reviewboard.kde.org/r/125314/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 19th, 2015, 3:53 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125314/diff/1/?file=404752#file404752line59" style="color: black; font-weight: bold; text-decoration: underline;">src/widgets/kbuildsycocaprogressdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KBuildSycocaProgressDialog::rebuildKSycoca(QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kbuildsycoca5</span><span class="p">.</span><span class="n">callWithCallback</span><span class="p">(</span><span class="s">"recreate"</span><span class="p">,</span> <span class="n">QVariantList</span><span class="p">(),</span> <span class="o">&</span><span class="n">dlg</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">_k_slotFinished</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QObject</span><span class="o">::</span><span class="n">connect</span><span class="p">(</span><span class="n">proc</span><span class="p">,</span> <span class="k">static_cast</span><span class="o"><</span><span class="kt">void</span> <span class="p">(</span><span class="n">QProcess</span><span class="o">::*</span><span class="p">)(</span><span class="kt">int</span><span class="p">)</span><span class="o">></span><span class="p">(</span><span class="o">&</span><span class="n">QProcess</span><span class="o">::</span><span class="n">finished</span><span class="p">),</span> <span class="o">&</span><span class="n">dlg</span><span class="p">,</span> <span class="p">[</span><span class="o">&</span><span class="n">dlg</span><span class="p">]()</span> <span class="p">{</span> <span class="n">dlg</span><span class="p">.</span><span class="n">d</span><span class="o">-></span><span class="n">_k_slotFinished</span><span class="p">();</span> <span class="p">});</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you close the dialog while the process is running? Does that destroy the process or does it continue? If it does continue does the lambda crash because dlg is gone? If it destroys the process is it something we care of the user should have just not closed the dialog?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Excellent point. I wanted to try this to see about reproducing bug 226732.
I tried and got it to crash ;)
QProcess dtor calls waitForFinished, which calls the slot, but d is already deleted. Ooops indeed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good catch, but your reasoning was slightly incorrect: if the dialog was fully deleted everything would be fine, the 3rd arg is &dlg so that it gets disconnected when dlg is destroyed.
The problem is that dlg is still alive (it's in ~QWidget), but d is not.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Q_PRIVATE_SLOT really works better with SIGNAL/SLOT....</p></pre>
<br />
<p>- David</p>
<br />
<p>On September 19th, 2015, 3:05 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2015, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=166792">166792</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dbus-callback stuff from kded is unreliable and unnecessary.
And meanwhile I made kbuildsycoca5 work well when called more
than once, the second instance will wait for the first one
and then check if there's anything else to do, otherwise quit early.
Change-Id: I24f62cf1015bdbab1778245f4221f03f40a9bd0f
BUGS: 235486, 166792
FIXED-IN: 5.15</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kpropertiesdialogtest <path to app desktop file>, changing the comment, clicking OK.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kbuildsycocaprogressdialog.cpp <span style="color: grey">(78d23dfda174f195e4c7fdfc1e128e83194326f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125314/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>