<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125279/">https://git.reviewboard.kde.org/r/125279/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125279/diff/1/?file=404435#file404435line688" style="color: black; font-weight: bold; text-decoration: underline;">src/sycoca/ksycoca.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">quint32 KSycoca::updateSignature()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">683</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">paths</span> <span class="o">=</span> <span class="n">QStandardPaths</span><span class="o">::</span><span class="n">standardLocations</span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">GenericDataLocation</span><span class="p">).</span><span class="n">join</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span class="n">QLatin1Char</span><span class="p">(</span><span class="sc">':'</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we want to qStableSort the list just in case?</p></pre>
</div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On setembre 16th, 2015, 11:30 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated set. 16, 2015, 11:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will prevent sycoca-rebuild ping-pong if two apps with different settings
would share the same file (and keep finding that it's wrong for them),
and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German
translations for the strings coming from desktop files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unittests, after adjusting ksycocatest which was checking for the old behavior (same file).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/ksycocatest.cpp <span style="color: grey">(7c2d91e056726540b8a3a5c679d9b2a93f023c50)</span></li>
<li>docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook <span style="color: grey">(3419e42cb29c6699bc17e6dd46bbc523139c59eb)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(3685211e9da68f14516ec2b3d9a7e6b4f559b6f3)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: grey">(c561dfd1550fd28e73144af6d3b2fa9008b17f59)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(c5465a828da615e87220304e3f8b160d471edbc7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125279/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>