<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125275/">https://git.reviewboard.kde.org/r/125275/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This removes the whole template magic and QThreadStorage for each factory,
and goes to a more object oriented design where the factories belong to
a ksycoca instance (= one per thread, plus one for rebuilding).
This even makes it possible to create another ksycoca instance with its
own factories, for special unittests (coming up).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ctest (3 times)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kmimeassociationstest.cpp <span style="color: grey">(5550938abe4d9c9c1ee698ac1b225312690e4aa6)</span></li>
<li>src/services/kmimetypefactory.cpp <span style="color: grey">(ba07aa0bc9b5d528454cf426b1feadb049402123)</span></li>
<li>src/services/kmimetypetrader.cpp <span style="color: grey">(702ef2913d3e218f53bb8b935e3d5ea19d66f7cc)</span></li>
<li>src/services/kplugininfo.cpp <span style="color: grey">(93dcb8fc35930d89e4e60efea755b018d329794f)</span></li>
<li>src/services/kservice.cpp <span style="color: grey">(045a2dad2775decf6bf427873b9fd1e292a1fe87)</span></li>
<li>src/services/kservicefactory.cpp <span style="color: grey">(9b0e0c199818fea774c08a4f8fab5aca417927c8)</span></li>
<li>src/services/kservicegroup.cpp <span style="color: grey">(50eed4a5c4d1917ce9a9d4a3ed617a5749b122d3)</span></li>
<li>src/services/kservicegroupfactory.cpp <span style="color: grey">(08e0bdcd765ab08afdb71cabc640fd21a73f4218)</span></li>
<li>src/services/kservicetype.cpp <span style="color: grey">(0ad453937d892d55725401dba024f95b95e91405)</span></li>
<li>src/services/kservicetypefactory.cpp <span style="color: grey">(62fd230b4f7a6558c707d257796c5967f39c3607)</span></li>
<li>src/services/kservicetypeprofile.cpp <span style="color: grey">(e4953a6333d044b77f983705036409a25c4fcb1c)</span></li>
<li>src/services/kservicetypetrader.cpp <span style="color: grey">(ca964e920bd7a9e0e6ab901d99b713b7ea7d3de3)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(3685211e9da68f14516ec2b3d9a7e6b4f559b6f3)</span></li>
<li>src/sycoca/kbuildsycoca_p.h <span style="color: grey">(c24413398694de29a788dd9498435572f5f605a3)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: grey">(c561dfd1550fd28e73144af6d3b2fa9008b17f59)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(c5465a828da615e87220304e3f8b160d471edbc7)</span></li>
<li>src/sycoca/ksycoca_p.h <span style="color: grey">(a86148a20fccf038e2d46f5d2d6d460be94910da)</span></li>
<li>src/sycoca/ksycocafactory_p.h <span style="color: grey">(c54bfc7b1ce917f11b6451f30863b374f2d94eb3)</span></li>
<li>src/sycoca/vfolder_menu.cpp <span style="color: grey">(b17ef2d371a2804ebe6029a0b7abfbebe4298d50)</span></li>
<li>src/sycoca/vfolder_menu_p.h <span style="color: grey">(b90f5efad903b73cbea7b40c142cc9e55e8c5bed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125275/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>