<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125272/">https://git.reviewboard.kde.org/r/125272/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On September 17th, 2015, 12:04 a.m. CEST, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 12:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This tests what happens now in applications, in order to catch any possible
issues with the in-process rebuild.
On the other hand, I left the QProcess usage in ksycocatest, so that this
one ensures the kbuildsycoca5 binary still works.
This change caught a nasty code path where the sycoca-header-check
during rebuild would actually trigger a rebuild, which would deadlock
on the lockfile. This bug was already in 5.14.0 but there the symptom
was harder to spot due to the process separation (constant rebuild, bug 352787).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unittests</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kmimeassociationstest.cpp <span style="color: grey">(5550938abe4d9c9c1ee698ac1b225312690e4aa6)</span></li>
<li>autotests/kservicetest.cpp <span style="color: grey">(ffd963dfc99fb52ce9c8546defc7148c1a982858)</span></li>
<li>autotests/ksycocadicttest.cpp <span style="color: grey">(52ce426fe2a0020f1952389420493f3ff6f32092)</span></li>
<li>autotests/ksycocathreadtest.cpp <span style="color: grey">(29a096fea2b1d315a4ca13e241a383d410fd157a)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(c5465a828da615e87220304e3f8b160d471edbc7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125272/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>