<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125253/">https://git.reviewboard.kde.org/r/125253/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2015, 8:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 8e37a422f489eb034597518513a110681d1331ff by David Faure to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will allow, in a next step, to rebuild the cache without calling
an external binary.
This change allows to export less classes from the lib, just for kbuildsycoca5's benefits
(of course KBuildSycoca itself must be exported).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">make, make install, make tests, kbuildsycoca5.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(e06f3e80f6b8bf8e894fac971454bae121451b90)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a82d260f7d6e4b9050aa0bb2bf70bac94ffc12cf)</span></li>
<li>src/kbuildsycoca/CMakeLists.txt <span style="color: grey">(d29963cb9bc1ee6c89668c669b01f5429db99d48)</span></li>
<li>src/kbuildsycoca/applications.menu <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildmimetypefactory.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildmimetypefactory_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildservicefactory.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildservicefactory_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildservicegroupfactory.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildservicegroupfactory_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildservicetypefactory.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildservicetypefactory_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildsycoca.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kbuildsycoca_p.h <span style="color: grey">(61d52a453d30a3c6d8b0d77995244f3628bdc463)</span></li>
<li>src/kbuildsycoca/kbuildsycocainterface_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kctimefactory.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kctimefactory_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kmimeassociations.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/kmimeassociations_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/ksycocaresourcelist_p.h <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/vfolder_menu.cpp <span style="color: grey">()</span></li>
<li>src/kbuildsycoca/vfolder_menu_p.h <span style="color: grey">()</span></li>
<li>src/services/kmimetypefactory_p.h <span style="color: grey">(299c9700a107d471e847e681f349d531170c580f)</span></li>
<li>src/services/kservicefactory_p.h <span style="color: grey">(35dcf9a9df8903fd3c33ef7910860991c9e20463)</span></li>
<li>src/services/kservicegroupfactory_p.h <span style="color: grey">(09ffd18949d42b0abc688619c45aa0b729730e7f)</span></li>
<li>src/services/kservicetypefactory_p.h <span style="color: grey">(520f7f8ad365f055191e3902cedc09b8659c95d0)</span></li>
<li>src/sycoca/kmemfile_p.h <span style="color: grey">(2aa9cb11b4b112085c347d3cc823473c5926f09e)</span></li>
<li>src/sycoca/ksycocafactory_p.h <span style="color: grey">(e2f5e839d251dff094bd526ead95319c5afb0a53)</span></li>
<li>src/sycoca/ksycocautils_p.h <span style="color: grey">(6110ea8a9bd62552eb07a92f2f9eb482a6cde897)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125253/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>