<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125274/">https://git.reviewboard.kde.org/r/125274/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On September 17th, 2015, 1:32 a.m. CEST, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 1:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code for reading it was already removed as part of b0c8fd8e64f,
the removal of the --checkstamps option.
The feature still exists anyway, a timestamp of "at least everything until
that time is in the DB" is in the sycoca header, and it used by the timestamp
check in ksycoca.cpp. This was an unnecessary separate file.
REVIEW: 125274</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook <span style="color: grey">(3419e42cb29c6699bc17e6dd46bbc523139c59eb)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(3685211e9da68f14516ec2b3d9a7e6b4f559b6f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125274/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>