<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125220/">https://git.reviewboard.kde.org/r/125220/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2015, 12:11 a.m. UTC, <b>Thiago Macieira</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Aye, QThreadStorage isn't meant to be used in a Q_GLOBAL_STATIC. I don't understand what you meant by id: QThreadStorageData::get can only be called once the construction has finished, in which case there aren't multiple threads racing.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, the race only exists <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">when</em> using Q_GLOBAL_STATIC ;)
In that case the QThreadStorage is created on demand, when there are multiple threads racing.
But your first sentence confirms it then, this change is correct.</p></pre>
<br />
<p>- David</p>
<br />
<p>On September 13th, 2015, 10:10 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Olivier Goffart and Thiago Macieira.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2015, 10:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Creating QThreadStorage on demand leads to race conditions because the
id of the storagedata gets assigned once multiple threads are running,
and read from other threads without locking. I almost submitted a fix for
Qt when I realized the indirection I had here was unnecessary and wrong.
QThreadStorage must be created in the main thread, before any thread is running.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">helgrind ksycocathreadtest no longer complains about a race on QThreadStorageData::id</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kservicetypefactory.cpp <span style="color: grey">(62fd230b4f7a6558c707d257796c5967f39c3607)</span></li>
<li>src/services/kservicegroupfactory.cpp <span style="color: grey">(08e0bdcd765ab08afdb71cabc640fd21a73f4218)</span></li>
<li>src/services/kservicefactory.cpp <span style="color: grey">(9b0e0c199818fea774c08a4f8fab5aca417927c8)</span></li>
<li>src/services/kmimetypefactory.cpp <span style="color: grey">(ba07aa0bc9b5d528454cf426b1feadb049402123)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125220/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>