<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125217/">https://git.reviewboard.kde.org/r/125217/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid and Michael Pyne.</div>
<div>By David Faure.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The use of KDirWatch from KSycoca exposed that KDirWatch was really not
thread-safe. The internal singleton design brings a ton of races between
KDirWatch instances. Easy solution: one "singleton" per thread, using
QThreadStorage.
The main impact is on memory management; the "singleton" is no longer refcounted
but simply deleted at the end of the thread, by QThreadStorage (including for
the main thread). Since this happens at ~QApp time, we need to zero the d pointer
of KDirWatch::self(), which is deleted by a global-static dtor later on.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unittests in kcoreaddons still pass, but now kservice's ksycocathreadtest passes every time, unlike before.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/io/kdirwatch.h <span style="color: grey">(f1593e73898c3610c2a560714ed608367120afa8)</span></li>
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(5e015c10cb99dbe4a21f944d4c0d0b364f2a7263)</span></li>
<li>src/lib/io/kdirwatch_p.h <span style="color: grey">(b2ac9d419bb0b0939a4eaa235a55634482db1cc6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125217/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>