<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125185/">https://git.reviewboard.kde.org/r/125185/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Albert Astals Cid and Ben Cooksley.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2015, 6:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit c7d4b69044c12394e1136d095674b0a30d03f9f4 by David Faure to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The list of changed resources is not longer available, so we fake it
by passing all 4 resources. No big deal, it just removes a small optimization
in some apps, and anyway the "apps" resource was emitted in all cases for the
last 8 years anyway (vfolder bug that was never fixed).
-> un-deprecate the old databaseChanged signal without the resource list ;)
KDirWatch beats QFileSystemWatcher once again, after much fighting with QFSW
with one failing unittest (KServiceTest::testThreads), I switched to KDirWatch
and it worked immediately...
REVIEW: 125185</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unittests still pass</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kbuildsycoca/CMakeLists.txt <span style="color: grey">(8c9fd73a73e4fb40461448a9c324990fc16e2bc1)</span></li>
<li>src/kbuildsycoca/kbuildsycoca_main.cpp <span style="color: grey">(4f39c470e474eaae6de9ade7ae5460edd6b00a82)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: grey">(f529e59c18f14f3367695d7a1f5cee74ab36b43d)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(93514eebec0a7d3b59445e555adf1146a3a00060)</span></li>
<li>src/sycoca/ksycoca_p.h <span style="color: grey">(a7d91e6d89b726d336f99bf43a65c16166c1d48e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125185/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>