<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125108/">https://git.reviewboard.kde.org/r/125108/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Logic looks solid :)</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On setembre 8th, 2015, 8:47 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated set. 8, 2015, 8:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(the options are kept to avoid breaking hypothetic callers, but do nothing anymore)
--checkstamps was a timestamp comparison to find out if kbuildsycoca should
do nothing. Let's not just call it in that case ;) A similar timestamp check
is in ksycoca.cpp since recently.
--nocheckfiles was an experimental and marked dangerous option,
to speed up KDE startup by only checking the global header (lang and dirs),
but not checking for modified desktop files. I guess the idea was for
binary packages to always ensure that ksycoca is updated. That's a very
long term plan with a fdo desktop-file-index, but not really applicable until then
(what if you install something from sources, on a distro set up that way...).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kservice unittests pass (but they don't really test these unused options ;)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook <span style="color: grey">(68e58db26262b7923adcdfc080bf18ffb7c805f6)</span></li>
<li>src/kbuildsycoca/kbuildsycoca.cpp <span style="color: grey">(3ce7ae425cfdfeac3264c5f4ecff440402402f7d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125108/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>