<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125048/">https://git.reviewboard.kde.org/r/125048/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 4th, 2015, 3:56 p.m. BST, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wasn't the reason for desktop files that we have infrastructure for translating desktop files but not json files?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(I could be wrong, of course).</p></pre>
</blockquote>
<p>On September 4th, 2015, 4:54 p.m. BST, <b>Alex Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I thought this has now been fixed and JSON files are also translated.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checking the git log on various JSON files in kdevplatform show commits by scripty adding translations so I am pretty sure this has been fixed.</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On September 4th, 2015, 3:18 p.m. BST, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2015, 3:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use JSON files directly instead of kcoreaddons_desktop_to_json()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookiejar.desktop <span style="color: grey">(3ea56abdc134cae22b69d7b7636ce6dd415a3d9b)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookiejar.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kpac/CMakeLists.txt <span style="color: grey">(fc5989714480ca49b5bd72e1c7b458b26bd0d9bc)</span></li>
<li>src/kpac/proxyscout.desktop <span style="color: grey">(a545f3d6ef2fd18b1a2c85ebff15c9f2513d87f1)</span></li>
<li>src/kpac/proxyscout.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kpasswdserver/CMakeLists.txt <span style="color: grey">(11c30201012fbe413ff58561b54255e88c2c55b9)</span></li>
<li>src/kpasswdserver/kpasswdserver.desktop <span style="color: grey">(bc788e5665e3d9d43309da241c3a3f5ac3cd0fc9)</span></li>
<li>src/kpasswdserver/kpasswdserver.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kssld/CMakeLists.txt <span style="color: grey">(bf6970c2741a6edd01e36b86744d643e70046889)</span></li>
<li>src/kssld/kssld.desktop <span style="color: grey">(86581b208ffc89fa5235f9284395d9d7ccebc472)</span></li>
<li>src/kssld/kssld.json <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125048/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>