<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124698/">https://git.reviewboard.kde.org/r/124698/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2015, 7:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit b90cbbe7436e58ef74e8526a969d9614af7971c2 by Elvis Angelaccio to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=224686">224686</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly trivial. This patch implements such an action in order to allow a user to show the password being typed. The action is only available if no password is given to the dialog as preset.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the icon: for now I've used <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">games-hint</code> from Breeze. Let me know whether there is a more relevant icon already available. If not, we can either request it or create a symlink for this one, e.g. <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">password-hint</code> or similar.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the last screenshot: the greyed icon is due to Qt bug <a href="https://bugreports.qt.io/browse/QTBUG-39660" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">39660</a>. Once fixed upstream (Qt 5.5?), the action will be properly hidden and there will be no icon greyed out.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Create a default KPasswordDialog. The new action is shown as soon as a password is being typed. The action is no more available as soon as the line edit is cleared.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Create a default KPasswordDialog, call <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">setPassword()</code> with a non-empty password and then show the dialog. The action is not available.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(1e664453623b4a03c07b9a478b2ca7e240cb949f)</span></li>
<li>src/icons.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/hint.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/visibility.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kpassworddialog.h <span style="color: grey">(9de2724640f483d5ab1134510fb84e1245814d90)</span></li>
<li>src/kpassworddialog.cpp <span style="color: grey">(3d348964b4c44d26c44856fc08c199007a195aca)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124698/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/e5333571-d38f-48bb-9b86-4e9ceb1a540b__kpassworddialog1.png">kpassworddialog1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/61f321e9-b940-49ad-bc49-1ef136bb758a__kpassworddialog2.png">kpassworddialog2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/6b66c26b-09ba-4f9b-852d-69271ffd46cd__kpassworddialog3.png">kpassworddialog3.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>