<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120443/">https://git.reviewboard.kde.org/r/120443/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2015, 12:19 p.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Bastian, are you still working on this? As it stands, the patch in its current form is proably not going into KTextEditor, as mentioned by Christoph.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are there still parts in this patch that are relevant? If so, can you update the patch to reflect it? Otherwise, please discard it (we can't do this, unfortunaltely, ReviewBoard is missing a "Reject" button) :-)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I discarded the review request and I will implement this feature in another way, later.</p></pre>
<br />
<p>- Bastian</p>
<br />
<p>On August 25th, 2015, 8:10 p.m. UTC, Bastian Holst wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Bastian Holst.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2015, 8:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add ctags configuration option to highlighting</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I need the added function to ask for the ctags command from kate's project plugin. I am still not sure if this is the right place to add the function. What do you think?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Testing with modified version of Kates project plugin (https://git.reviewboard.kde.org/r/120444/).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/document/katedocument.cpp <span style="color: grey">(82363ed73bac515918b99d935cfc53d667bde3f7)</span></li>
<li>src/include/ktexteditor/mainwindow.h <span style="color: grey">(bfee68a6536282d4ac58fc6adf16349b0d514d0b)</span></li>
<li>src/mode/katemodemanager.h <span style="color: grey">(e249913483cd184e9c66066bc49907fd49325a9d)</span></li>
<li>src/mode/katemodemanager.cpp <span style="color: grey">(694ca6219c80b8812f86912e58f3c14fe9324f92)</span></li>
<li>src/syntax/data/haskell.xml <span style="color: grey">(f0e7f8f955ea9cd56795add8de03c6627313301a)</span></li>
<li>src/syntax/data/katehighlightingindexer.cpp <span style="color: grey">(3f02e8c2a76e471489bc6df2a9f4ac0463c3afe0)</span></li>
<li>src/syntax/data/language.xsd <span style="color: grey">(3f20304efe9c7a29df0dbe0a822196ec612437e8)</span></li>
<li>src/syntax/data/literate-haskell.xml <span style="color: grey">(f69dbc56d7effbfa02398456cea616f0fce2d706)</span></li>
<li>src/syntax/katehighlight.h <span style="color: grey">(237cf1a1837a4cf7d530be5a6a74ba9df7d0f8b7)</span></li>
<li>src/syntax/katesyntaxmanager.h <span style="color: grey">(94c2b597cb0935feea01e454ba92eddc24be7af6)</span></li>
<li>src/syntax/katesyntaxmanager.cpp <span style="color: grey">(c51fbaf9eb230dfd1fb1602000860bf21a5cd8ce)</span></li>
<li>src/utils/mainwindow.cpp <span style="color: grey">(6e664a9e7d0d9301ef12d9b1d7050fa2e3007d6f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120443/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>