<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124772/">https://git.reviewboard.kde.org/r/124772/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2015, 9:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 173a9c5768bbc73e1a825d1441cc8cf2c5b7b832 by David Faure to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">except in lex/yacc generated code, some -Wmissing-prototypes cases (including in Qt macros),
moc calling deprecated methods, and two if(false) in substring support (for which I emailed aseigo).
My flags:
-Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-exit-time-destructors -Wno-padded -Wno-sign-conversion -Wno-documentation -Wno-undefined-reinterpret-cast -Wno-shorten-64-to-32 -Wno-conversion -Wno-gnu-zero-variadic-macro-arguments -Wno-global-constructors -Wno-shadow -Werror=format-security -Werror=return-type -Wno-variadic-macros -Wmissing-include-dirs -Wno-used-but-marked-unused -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -pedantic -std=c++0x -fdeprecated-macro -fdebug-compilation-dir</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles, unit tests pass</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kautostart.cpp <span style="color: grey">(d140aabd42f9f0e3c1fd50d559209347b5d5134e)</span></li>
<li>src/kbuildsycoca/vfolder_menu.cpp <span style="color: grey">(2b3aa5c7e8eda40c4ef14295e045966b50bfc5c0)</span></li>
<li>src/kbuildsycoca/ksycocaresourcelist.h <span style="color: grey">(bcc4efa1ef3d98b4e34f69bf027df10616a1c696)</span></li>
<li>autotests/kautostarttest.cpp <span style="color: grey">(233fbe26abc1ec252605ca3ed8c3270dd3ab375f)</span></li>
<li>autotests/kmimeassociationstest.cpp <span style="color: grey">(74c85c696e71caedf6c4c488d052fda26cc9cd61)</span></li>
<li>autotests/kservicetest.cpp <span style="color: grey">(00940f8b4ca01d4cbc2fe3db2172b1efe4d6ef69)</span></li>
<li>autotests/ksycocadicttest.cpp <span style="color: grey">(69e338869a533e653a49bddbf1eab76505c1c14a)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(35154a597f55313847b8140962c0e2a4cf1c15a2)</span></li>
<li>src/kbuildsycoca/kbuildmimetypefactory.cpp <span style="color: grey">(c2856882b80c8e5c52d5893e72da060195ab1d48)</span></li>
<li>src/kbuildsycoca/kbuildservicefactory.cpp <span style="color: grey">(ea76374e421f274b1d8fc4d5e49002689e424894)</span></li>
<li>src/kbuildsycoca/kbuildservicegroupfactory.cpp <span style="color: grey">(199b6c4b0c20e99d3212a31b7a50e53d5f028028)</span></li>
<li>src/kbuildsycoca/kbuildservicetypefactory.cpp <span style="color: grey">(40c4758041bb53abba8d7ab1c2fdc1d426890fa6)</span></li>
<li>src/kbuildsycoca/kbuildsycoca.cpp <span style="color: grey">(3ab77c4c93537be49810149185af72d57060aa4d)</span></li>
<li>src/kbuildsycoca/kbuildsycocainterface.h <span style="color: grey">(fcf891007e34e51a8bbfea95a138aa822dd1a8d8)</span></li>
<li>src/kbuildsycoca/kctimefactory.cpp <span style="color: grey">(ceccdf29892214f5f347fc3377454f4529ba4ab0)</span></li>
<li>src/services/kmimetypefactory.cpp <span style="color: grey">(0cd81d4e2157f5a96e86df56b325d87bda810da5)</span></li>
<li>src/services/kmimetypefactory_p.h <span style="color: grey">(ae399d86d9d4083242812f55b7cb8064a9fbe7f9)</span></li>
<li>src/services/kservice.cpp <span style="color: grey">(c4a96e1aadb955d036b06fce5c36ac41cb3d6bbd)</span></li>
<li>src/services/kservicefactory.cpp <span style="color: grey">(f5e4412955a7c0ff455defcb49f9fb918a4617c7)</span></li>
<li>src/services/kservicegroup.cpp <span style="color: grey">(b182b5a87cedf62797889805c7f2ee9e05363361)</span></li>
<li>src/services/kservicegroup_p.h <span style="color: grey">(1f8f8bd3cfbc18e572ec91992105e7c633c9b8d4)</span></li>
<li>src/services/kservicegroupfactory.cpp <span style="color: grey">(8ddac31342bda7a0c022aa46c3a0ffd57c746b74)</span></li>
<li>src/services/kservicetype.cpp <span style="color: grey">(d881371c76bca78df9cbe4cf793a9928c3a29a23)</span></li>
<li>src/services/kservicetypefactory.cpp <span style="color: grey">(7eab5e6a4020e88dcfa43ab4eae325895fd3a289)</span></li>
<li>src/services/ktraderparse.cpp <span style="color: grey">(670b79342a81be3cd6461b9b510d842375574fc3)</span></li>
<li>src/services/ktraderparsetree.cpp <span style="color: grey">(bef271d06109a6701f34ee32bdd724cdadbb51b1)</span></li>
<li>src/services/ktraderparsetree_p.h <span style="color: grey">(9b914fd45e24b5acec206e9708b643a8b1883b51)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(da21b9ee83fe45fc3f31400f86bcd9fbbd7d850e)</span></li>
<li>src/sycoca/ksycocadevices.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sycoca/ksycocadevices_p.h <span style="color: grey">(195b24cc99282debb1640e7d942ec07e27d4b01b)</span></li>
<li>src/sycoca/ksycocadict.cpp <span style="color: grey">(2dc25d82506065910221e0ce191d8799d5a734fd)</span></li>
<li>src/sycoca/ksycocafactory.cpp <span style="color: grey">(b07e68870130c656d2b7b3d96977f4970cbec531)</span></li>
<li>src/sycoca/ksycocautils.cpp <span style="color: grey">(87890d2416f490398e1cb4f11e6473672644fea4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124772/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>