<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124607/">https://git.reviewboard.kde.org/r/124607/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Vishesh Handa.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2015, 8:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove unused return value</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes threads without an event loop (e.g. in krunner) never noticing
changes in ksycoca.
Done-with: Vishesh Handa</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The improved unittest was failing with threadsWhoSawFakeService() always only 2 out of 5 (the 2 threads with an event loop). Passes now.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/ksycocathreadtest.cpp <span style="color: grey">(0d6ed4b89581fc506ea79c32c1de314637decf3e)</span></li>
<li>src/services/kmimetypetrader.cpp <span style="color: grey">(655e5de9d272176e06af48a8417ea06e2412b9d8)</span></li>
<li>src/services/kplugininfo.cpp <span style="color: grey">(56dc0b43036a2a49804ff799360c29c2121dda54)</span></li>
<li>src/services/kservice.cpp <span style="color: grey">(3639a2875e5dbaefc6511d36d7b7f0fb7697ea74)</span></li>
<li>src/services/kservicegroup.cpp <span style="color: grey">(a2905da347877ccf34677776b63bd0eae518101f)</span></li>
<li>src/services/kservicetype.cpp <span style="color: grey">(5e71351e5b7a0acef96104d8d14fa5b27817595d)</span></li>
<li>src/services/kservicetypetrader.cpp <span style="color: grey">(290e44e9161c8db47278543714426fdd3b5a87af)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: grey">(542029c7c21d495456065e51b485a26509152cd5)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(32d1689ad9cd01d3a8adb5123a1848278714ca95)</span></li>
<li>src/sycoca/ksycoca_p.h <span style="color: grey">(393cfcf8f04c369ac9c03712d917c49112771838)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124607/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>