<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124371/">https://git.reviewboard.kde.org/r/124371/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 16th, 2015, 2:49 p.m. CEST, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1, though I remember sebas also tried to fix some recursive loop here sometime ago..</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tree b2e50f720e779924ffbc9211c935cb433894337a <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
parent 2d7dfd214789ec140306eb18971689909692deae <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
author Sebastian Kügler <a href="mailto:sebas@kde.org" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">sebas@kde.org</a> Thu Jan 29 13:35:31 2015 +0100 <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
committer Sebastian Kügler <a href="mailto:sebas@kde.org" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">sebas@kde.org</a> Thu Jan 29 13:35:31 2015 +0100 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix fallback from invalid L&F packages </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The mechanism should have deleted the old key from the config if it was <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
invalid and then try again in order to get the default. As we were <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
deleting the wrong key (actually the value of the shell package key), <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
this was turning into a recursive loop. Deleting the correct key <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
obviously fixes this. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks Bille for reporting! </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reviewed-by: Marco Martin </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG:343510</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's a fix in the right direction, but the key is still wrong :-)</p></pre>
<br />
<p>- Daniel</p>
<br />
<p>On July 16th, 2015, 1:38 p.m. CEST, Daniel Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Marco Martin.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated July 16, 2015, 1:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">LookAndFeel</code> entry does not exist in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kdeglobals</code> (it's called <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">LookAndFeelPackage</code>), so when the configured LnF package is removed or renamed, the code will go to endless loop because it never clears the configuration ine <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kdeglobals</code> correctly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We discovered this in Fedora, because we ship our own ugly LnF package, and we renamed it at some point, which caused KDED to go nuts.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformstatus/platformstatus.cpp <span style="color: grey">(e03c16d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124371/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>