<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124282/">https://git.reviewboard.kde.org/r/124282/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Jesse Jaara.</div>
<p style="color: grey;"><i>Updated July 10, 2015, 12:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 30d28a41737140ef69369d5c84d9bcd6a4321cdb by Milian Wolff on behalf of Jesse Jaara to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Implement Voikko based spellchecker for Sonnet</h1>
<h2 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Description</h2>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implements a spell chekcing plugin based on libvoikko <a href="http://voikko.puimula.org/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">http://voikko.puimula.org/</a>.
Primarily for supporting highquality Finnishs spell checking, but HFST trancuders
can be found several other languages too.
<a href="http://sourceforge.net/projects/hfst/files/resources/spell-transducers/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">http://sourceforge.net/projects/hfst/files/resources/spell-transducers/</a></p>
<h2 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">List of commits (oldest 1st)</h2>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Define QLoggingCategory for for voikko speller plugin</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Declared SONNET_VOIKKO QLoggingCategory</li>
</ul>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implement Voikko based spellchecker (dictionary)</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">All Sonnet::SpellerPlugin functions are implemented.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">storeReplacement() and addToPersonal() use Json based storage.<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">File location:<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">UNIX & OSX: QStandardPaths::GenericDataLocation/Sonnet/Voikko-user-dictionary.json</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Windows >= Vista: QSP::GenericDataLocation/../Roaming/Sonnet/Voikko-user-dictionary.json</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">XP: QSP::GenericDataLocation/../../Aplication Data/Sonnet/Voikko-user-dictionary.json</li>
</ul>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Format:</li>
</ul>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">{ <span style="color: #008000; font-weight: bold">"<languageId>"</span>: {
<span style="color: #008000; font-weight: bold">"PersonalWords"</span>: [
<span style="color: #BA2121">"word"</span>
],
<span style="color: #008000; font-weight: bold">"Replacements"</span>: [
{<span style="color: #008000; font-weight: bold">"bad"</span>: <span style="color: #BA2121">"eror"</span>,
<span style="color: #008000; font-weight: bold">"good"</span>: <span style="color: #BA2121">"error"</span>}
]
}
</pre></div>
</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Before use VoikkoDict based chekkers must be ensured to be with valid with initFailed().
As so the ctor is protected and only accessible from friens class VoikkoClient, which
does this check before returning the speller. Using an invalid speller will result in
null-pointer exceptions.</li>
</ul>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implement Sonnet::Client for Voikko speller</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Reliability set to 50.
Voikko is primarily only used for Finnish at the moment, although
the HFST transducer-backend has added support for other languages
of varying quality.
As for Finnish (99% of use cases) the results are top quality.</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In any case the reliability should be higher than that of hunspell
and aspell to prevent them from kicking in for Finnish, as the
Finnish dictionarys for them are low-quality.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Name is "Voikko"</li>
</ul>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add in CMakeBits needed to compile Voikko speller.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Added FindVOIKKO module</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindVOIKKO.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/CMakeLists.txt <span style="color: grey">(3d24d61)</span></li>
<li>src/plugins/voikko/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/voikko/voikkoclient.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/voikko/voikkoclient.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/voikko/voikkodebug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/voikko/voikkodebug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/voikko/voikkodict.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/voikko/voikkodict.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124282/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/10/174028b1-4e2b-454d-b15e-fdb4f2e44db6__0001-Define-QLoggingCategory-for-for-Voikko-based-speller.patch">0001-Define-QLoggingCategory-for-for-Voikko-based-speller.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/10/8c0e2295-f19b-49e9-bc7d-11576cb167c5__0002-Implement-Voikko-based-spell-checker-Sonnet-SpellerP.patch">0002-Implement-Voikko-based-spell-checker-Sonnet-Speller.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/10/1d8107b2-a1b2-43a8-b0c6-eda5023a5144__0003-Implement-Sonnet-Client-factory-for-Voikko-spell-che.patch">0003-Implement-Sonnet-Client-factory-for-Voikko-spell-che.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/10/8177a1d7-f9d4-4b0c-a602-25d8f77c5472__0004-Add-in-CMake-bits-to-enable-building-of-Voikko-plugi.patch">0004-Add-in-CMake-bits-to-enable-building-of-Voikko-plugi.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>