<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124222/">https://git.reviewboard.kde.org/r/124222/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124222/diff/2/?file=382226#file382226line213" style="color: black; font-weight: bold; text-decoration: underline;">src/kidletime.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">199</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Using"</span> <span class="o"><<</span> <span class="n">candidate</span> <span class="o"><<</span> <span class="s">"for platform"</span> <span class="o"><<</span> <span class="n">QGuiApplication</span><span class="o">::</span><span class="n">platformName</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">qCDebug!</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1, LGTM</p></pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 2nd, 2015, 2:14 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 2, 2015, 2:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kidletime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of having the platform specific implementations hard compiled
in, they are split out into plugins which can get loaded at runtime
depending on the platform we are in.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tried the example app on X11: it correctly loads the xsync plugin. If I modify it to be not available it correctly loads the xscreensaver plugin. In both cases the interaction is correct.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With --platform wayland no plugin gets loaded (as expected) and the functionality is pretty much broken.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Osx and Windows are obviously neither compile nor runtime tested. But I adjusted the code to my best knowledge.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(23e5e2914e3a8991d14b664d80ac0d4b60545b40)</span></li>
<li>src/abstractsystempoller.h <span style="color: grey">(00202d00b19fbbbd7443e07e411bdedecca230ee)</span></li>
<li>src/kidletime.cpp <span style="color: grey">(fc4ce77454db52d1bbaf9831c378f22548a237a7)</span></li>
<li>src/macpoller.h <span style="color: grey">(aab6a3acc16d5fb2b9a3156a142125a15d7e610f)</span></li>
<li>src/macpoller.cpp <span style="color: grey">()</span></li>
<li>src/org.freedesktop.ScreenSaver.xml <span style="color: grey">()</span></li>
<li>src/plugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/osx/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/osx/osx.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/windows/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/windows/windows.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/xscreensaver/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/xscreensaver/xcb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/xsync/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/xsync/fixx11h.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/xsync/xcb.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/widgetbasedpoller.h <span style="color: grey">(fac0a724d32fb79a3c9b7829cba3b17f03bfff32)</span></li>
<li>src/windowspoller.h <span style="color: grey">(502ed6dd6c6eaae1b35a14dce66812ebec30677e)</span></li>
<li>src/windowspoller.cpp <span style="color: grey">()</span></li>
<li>src/xscreensaverbasedpoller.h <span style="color: grey">(363ec521faa39e5b996c9e6767171f72005d11ca)</span></li>
<li>src/xscreensaverbasedpoller.cpp <span style="color: grey">()</span></li>
<li>src/xsyncbasedpoller.h <span style="color: grey">(8f67cbed38519e15cf5a96b5086da348ec8fabd5)</span></li>
<li>src/xsyncbasedpoller.cpp <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124222/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>