<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124165/">https://git.reviewboard.kde.org/r/124165/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2015, 8:40 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124165/diff/3/?file=381630#file381630line684" style="color: black; font-weight: bold; text-decoration: underline;">src/karchive.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">684</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">perms</span> <span class="o">%</span> <span class="mi">2</span> <span class="o">==</span> <span class="mi">1</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The "/8 /8 %2" bit looks too arithmetic to me, this should be 'bitwise and' instead (faster, more approriate here, and IMHO more readable).
We can't use S_IXUSR(perms), S_IXGRP(perms) and S_IXOTH(perms) due to windows portability, so I would suggest this instead:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if (perm & 01)
ret |= QFileDevice::ExeOther;
if (perm & 010)
ret |= QFileDevice::ExeGroup;
if (perm & 0100)
ret |= QFileDevice::ExeOwner;</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, QFileDevice::Permissions is a QFlags, so no casting needed. Declare
QFileDevice::Permission ret = filePerms;
and "return ret;"</p></pre>
</blockquote>
<p>On June 29th, 2015, 9:15 a.m. UTC, <b>Romário Rios</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, QFileDevice::Permissions is a QFlags, so no casting needed. Declare
QFileDevice::Permission ret = filePerms;
and "return ret;"</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About that...:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #BC7A00">[</span> <span style="color: #666666">31%</span><span style="color: #BC7A00">]</span> Building CXX object src<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>KF5Archive.dir<span style="color: #666666">/</span>karchive.cpp.o
<span style="border: 1px solid #FF0000">/home/luizromario/karchive/src/karchive.cpp: In function 'QFileDevice::Permission withExecutablePerms(QFileDevice::Permissions, mode_t)':</span>
<span style="border: 1px solid #FF0000">/home/luizromario/karchive/src/karchive.cpp:682:35: error: invalid conversion from 'QFlags<QFileDevice::Permission>::Int {aka int}' to 'QFileDevice::Permission' </span><span style="color: #BC7A00">[</span><span style="color: #7D9029">-fpermissive</span><span style="color: #BC7A00">]</span>
<span style="border: 1px solid #FF0000">/home/luizromario/karchive/src/karchive.cpp:685:27: error: invalid conversion from 'int' to 'QFileDevice::Permission' </span><span style="color: #BC7A00">[</span><span style="color: #7D9029">-fpermissive</span><span style="color: #BC7A00">]</span>
<span style="border: 1px solid #FF0000">/home/luizromario/karchive/src/karchive.cpp:688:27: error: invalid conversion from 'int' to 'QFileDevice::Permission' </span><span style="color: #BC7A00">[</span><span style="color: #7D9029">-fpermissive</span><span style="color: #BC7A00">]</span>
<span style="border: 1px solid #FF0000">/home/luizromario/karchive/src/karchive.cpp:691:27: error: invalid conversion from 'int' to 'QFileDevice::Permission' </span><span style="color: #BC7A00">[</span><span style="color: #7D9029">-fpermissive</span><span style="color: #BC7A00">]</span>
</pre></div>
</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My bad, I forgot the 's' in my suggested code. It's</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QFileDevice::Permissions ret = filePerms;</p></pre>
<br />
<p>- David</p>
<br />
<p>On June 28th, 2015, 10:31 a.m. UTC, Romário Rios wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Romário Rios.</div>
<p style="color: grey;"><i>Updated June 28, 2015, 10:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The KArchiveFile::copyTo() doesn't set the permissions of the files it copies -- it just copies the data. So if an archive contains an executable, it's extracted from the archive as a non-executable. This patch makes it apply the executable permissions found in the KArchiveFile to the QFile being copied.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems to work for all files (tested with xz and zip files containing executables, directories, text, etc.).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/karchivetest.cpp <span style="color: grey">(afc8387)</span></li>
<li>src/karchive.cpp <span style="color: grey">(344cba8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124165/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>