<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124133/">https://git.reviewboard.kde.org/r/124133/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 20th, 2015, 9:10 p.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 for adding all that info
-1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add there...</p></pre>
</blockquote>
<p>On June 20th, 2015, 9:34 p.m. CEST, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Putting more and more versions there doesn't scale. Just cramming more and more stuff in there doesn't really make it more beautiful, putting it into its own tab means that the information is neatly organized.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, the version is really an implementation detail, and having one version there will often yield another round of asking ("Which versions are you running? - "version x.y.z" - "No, I need the versions that are shown in the tab, so also frameworks, Qt, and whether it runs on wayland or X11."</p></pre>
</blockquote>
<p>On June 21st, 2015, 1:20 a.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Honestly the only time I've seen/told anyone open that dialog was to get the app version number. This was previously visible right away, now it's hidden in an additional click. Could perhaps be at least made the first/default tab?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"and having one version there will often yield another round of asking"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure I understand what you're getting at, but given there was only one version string in that dialog for longlonglong time, I've never hit the scenairo you're describing. My idea was to do this:</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KWrite</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Version 5.0.0
Using KDE Frameworks 5.12.0
Qt 5.4.2 (built against 5.4.2); xcb/wayland</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">...ie. just add one more line below the current data set in the main layout and have no version tab at all; all the data visible right away after opening the dialog. It doesn't need to scale as there are no more version numbers to put there (unless we want to put everything in there).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">one of the thoughts was also to give applications a possibility to easily add more information about it. E.g. in KWin the supportInformation (we don't have an about dialog) there are about 10 individual version/compile information put out. So while you didn't have the need yet, I experienced this need in the past a lot.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Concerning first tab: not sure. Is this the most important information? And even if: do users count the clicks? I doubt it.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On June 20th, 2015, 6:30 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 20, 2015, 6:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This replaces the version information of the version and frameworks and
moves it into a dedicated tab. In this tab the information is extended
by the Qt version (which is equally relevant as e.g. the frameworks
version) in both runtime and compile time.
Also windowing system is added. This will become a useful information
for KWin developers starting in Plasma 5.4 when users start to test
things out and we need to know whether the window they experience the
problem with is running on wayland or xwayland.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kaboutapplicationdialog.cpp <span style="color: grey">(5eeea7711aa4f95a9cd4191d68ad330ef795caea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124133/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/20/b76ba6ae-b01c-4c6a-9248-29d39c652d83__snapshot_J11265.png">New wayland, new X11, old X11</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>