<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123867/">https://git.reviewboard.kde.org/r/123867/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 25th, 2015, 11:09 p.m. IST, <b>Allen Winter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is incorrect. std::abs comes from cstdlib, not cmath
please fix accordingly. I have it compiling here fine on my macbook with #include <cstdlib> instead of #include <cmath></p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed with http://commits.kde.org/ki18n/f0a4b6f1564efe397d804ac4ad1740c811748c6b</p></pre>
<br />
<p>- Bhushan</p>
<br />
<p>On May 21st, 2015, 1:49 p.m. IST, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett Clark.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated May 21, 2015, 1:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console
Follow up to,
commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
Author: Milian Wolff <mail@milianw.de>
Date: Mon May 18 10:52:29 2015 +0200
Fix compiler warning about potential truncation.
klocalizedstring.cpp:1126:46: warning: absolute value function 'abs'
given an argument of type 'long' but has parameter of type 'int'
which may cause truncation of value
kls.d->number = static_cast<pluraln>(abs(a));
^
klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klocalizedstring.cpp <span style="color: grey">(910f44d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123867/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>