<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123803/">https://git.reviewboard.kde.org/r/123803/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 15th, 2015, 9:49 p.m. CEST, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About your commit log: we won't have a different coding style for karchive, all frameworks should follow
https://techbase.kde.org/Policies/Kdelibs_Coding_Style
and
https://techbase.kde.org/Policies/Library_Code_Policy</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the diff: so this is the result of uncrustify, not astyle? Can you put the uncrustify script in kde-dev-scripts too?</p></pre>
</blockquote>
<p>On May 17th, 2015, 5:55 p.m. CEST, <b>Guy Maurel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found a problem with the two references you give:
The first says:
For pointers or references, use a single space before '*' or '&', but not after
The second:
QString myMethod( const QString& foo,
which one is to follow?
The diff I provided is a product of astyle with some more scripts (not provided by astyle).
uncrustify provides much more diversity (500 options). Is more complicate.
I am working on uncrustify to provide an uncrustiy script to follow the kdelibs.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The first one is to follow; the second link (Library_Code_Policy) says on top "For kdelibs, it is recommended to follow the Kdelibs Coding Style."</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That page however should be edited to follow the kdelibs style too (it's currently moreless random).</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On May 17th, 2015, 6:03 p.m. CEST, Guy Maurel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Mario Bensi and David Faure.</div>
<div>By Guy Maurel.</div>
<p style="color: grey;"><i>Updated May 17, 2015, 6:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We use for karchive the same rules as for kdepim:
http://techbase.kde.org/Policies/Kdepim_Coding_Style
If wished, we could have extra policy for karchive.
(Let me know)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/k7zip.cpp <span style="color: grey">(edd1090234e34d669f42815c9d2c653291c0fd2a)</span></li>
<li>src/kar.cpp <span style="color: grey">(fb31185)</span></li>
<li>src/karchive.cpp <span style="color: grey">(1b3371b1479581eb1d83f8f245cf3b85677517d0)</span></li>
<li>src/kbzip2filter.cpp <span style="color: grey">(52acb76)</span></li>
<li>src/kcompressiondevice.cpp <span style="color: grey">(05d6859)</span></li>
<li>src/kfilterdev.cpp <span style="color: grey">(dd9e6a3)</span></li>
<li>src/kgzipfilter.cpp <span style="color: grey">(160cff57d851820f92c99da6a2fe034ebdd4c8b5)</span></li>
<li>src/klimitediodevice.cpp <span style="color: grey">(66b9b3d)</span></li>
<li>src/knonefilter.cpp <span style="color: grey">(055fab9)</span></li>
<li>src/krcc.cpp <span style="color: grey">(cb8b2cca8262ed0986cc52d01c7b44d5662d1dd5)</span></li>
<li>src/ktar.cpp <span style="color: grey">(1386382939bb0f0e3a0b9b2b841b909a03ec6e85)</span></li>
<li>src/kxzfilter.cpp <span style="color: grey">(0e7ae09ccae30e179d63400de921c259e832cb2a)</span></li>
<li>src/kzip.cpp <span style="color: grey">(4bbbcf5464a9e5aae305798201fda641e5b744f2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>