<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123707/">https://git.reviewboard.kde.org/r/123707/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If filePath() is relative, it can't be used in a discard command. I assume you meant "always absolute". This is true in your case (SimpleConfig) but not in all cases.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The method filePath() itself assumes a file-based backend (once in the past there was an idea of an ldap-based backend, or a binary db...).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure which of the two solutions I prefer:
1) filePath() method, but documented to only make sense for SimpleConfig objects
2) using QStandardPaths to find the file from KConfig::name(). This is done a lot more than you think ;) </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In fact the KConfig constructor takes a QStandardPaths::StandardLocation optional 3rd argument. So it's not unreasonable to look up KConfig::name() in there.... it's just that in general it'll be a locateAll(), not just a locate() (which is good enough for SimpleConfig).
So yeah no LDAP there :-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think option 2 is better than providing an API that will make KConfig users shoot themselves in the foot.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On May 10th, 2015, 5:11 p.m. UTC, Stefan Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Rex Dieter.</div>
<div>By Stefan Becker.</div>
<p style="color: grey;"><i>Updated May 10, 2015, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=346768">346768</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If KConfig object provides a non-empty file path then set the session manager discard command to "rm <file path>". This makes sure that obsolete session files are deleted after creating a new one.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">F22 kwrite & konsole, ksmserver and "Save Session..."</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kconfig.h <span style="color: grey">(6cc7323)</span></li>
<li>src/core/kconfig.cpp <span style="color: grey">(3819716)</span></li>
<li>src/gui/kconfiggui.h <span style="color: grey">(173400f)</span></li>
<li>src/gui/kconfiggui.cpp <span style="color: grey">(0048c60)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123707/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>