<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123532/">https://git.reviewboard.kde.org/r/123532/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On duben 28th, 2015, 4:09 odp. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It worked here, so it's a +1 from me. I just would like the extra-cmake-module maintainer to give the final "ship it".</p></pre>
</blockquote>
<p>On duben 29th, 2015, 7:16 dop. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, I realized that this would break backward compatibility with plasma-nm, because in plasma-nm we use NETWORKMANAGER_VERSION and not NetworkManager_VERSION. I was trying to use NETWORKMANAGER prefix, but there was a problem with pkg_check_modules, which automatically sets NETWORKMANAGER_VERSION, NETWORKMANAGER_FOUND and NETWORKMANAGER_INCLUDE_DIRS and I couldn't use those variables anymore without using unset(foo) or something else. Any idea how to solve this problem? Is it possible to return two variables in VERSION_VAR?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actually, thinking about it, plasma-nm has own copy of FindNetworkManager.cmake, so if we force to use this one, it should still work even with newer version of frameworks and for 5.4.0 we can set dependency on this and remove the local copy.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On duben 27th, 2015, 2:38 odp. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Dub. 27, 2015, 2:38 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds FindModemManager.cmake and FindNetworkManager.cmake into other find modules. These are required for modemmanager-qt and networkmanager-qt, which are currently missing public dependencies on ModemManager/NetworkManager and to be able to add them, we need to have these find modules publicly available. Note, that my knowledge of CMake is quite limited, so proper review would be needed :).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindModemManager.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>find-modules/FindNetworkManager.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123532/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>