<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123367/">https://git.reviewboard.kde.org/r/123367/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 24th, 2015, 2:47 p.m. EDT, <b>Matthew Dawson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123367/diff/7-8/?file=362762#file362762line33" style="color: black; font-weight: bold; text-decoration: underline;">autotests/kconfig_compiler/test13.cpp.ref</a>
<span style="font-weight: normal;">
(Diff revisions 7 - 8)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> Q_EMIT brightnessModified();</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is there a reason this got moved back?</p></pre>
</blockquote>
<p>On April 24th, 2015, 8:29 p.m. EDT, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, Modified needs to be called together with Changed, because it's called when it changes. Right?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I left it there because it seemed to me it was fine there, am I wrong? In fact, I was thinking about just connecting Changed to modified, but I guessed this was more explicit.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggested the extra signal, that way when the KConfigSkeleton loads new values from the underlying KConfig the QML code would get notified. But if the check is in usrWriteConfig, then that value change won't be picked up until the save function is called. It seems brightnessChanged type signals are used for a different purpose (notifying about changes on save), so just using that won't work.</p></pre>
<br />
<p>- Matthew</p>
<br />
<p>On April 24th, 2015, 12:56 p.m. EDT, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated April 24, 2015, 12:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The generation of those classes makes it useful to have these being used within C++ application. This change makes it possible to use these classes from QML as well.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For each variable, exposes the getter. In case there's a setter, it will add a notify signal and the setter to the property.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KConfig tests still pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(0cca605)</span></li>
<li>autotests/kconfig_compiler/kconfigcompiler_test.cpp <span style="color: grey">(43623ce)</span></li>
<li>autotests/kconfig_compiler/test13.cpp.ref <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13.h.ref <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test13main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/test_signal.cpp.ref <span style="color: grey">(58e73ef)</span></li>
<li>autotests/kconfig_compiler/test_signal.h.ref <span style="color: grey">(19b8b40)</span></li>
<li>src/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(5aae340)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123367/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>