<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123401/">https://git.reviewboard.kde.org/r/123401/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2015, 6:16 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wouldn't it have been easier to add the subdirectory in the interface?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Or you want users of the library to specify the namespace?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also the former one would have been fine as long as the header and the export file are in the same directory, which seems to be the case...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe it would be easier, but this seems to be indeed namespaced framework, same like Solid and KParts.
David's commit is correct, though it uncovered further problems in this frameworks, and it's consumers.
It is now indeed the question whether to make networkmanager-qt correctly export and install it's headers at the cost of a SiC (even though the SiC is triggered by incorrect usage of includes)...</p></pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On April 17th, 2015, 5:53 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Jan Grulich.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated April 17, 2015, 5:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
networkmanager-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The headers include <networkmanagerqt_export.h>, which is now in lowercase directory, and is not in public INTERFACE includes. We need to change all the includes, and place where the export is generated.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plasma-nm no longer fails due to original problem, but incorect usage of nm-qt includes:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">vpnuiplugin.h:31:43: fatal error: NetworkManagerQt/generictypes.h: No such file or directory</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(0dc3f2e)</span></li>
<li>src/accesspoint.h <span style="color: grey">(99895ef)</span></li>
<li>src/activeconnection.h <span style="color: grey">(6edd0ae)</span></li>
<li>src/adsldevice.h <span style="color: grey">(d7c92ba)</span></li>
<li>src/bluetoothdevice.h <span style="color: grey">(4baf4a3)</span></li>
<li>src/bonddevice.h <span style="color: grey">(82eafa2)</span></li>
<li>src/bridgedevice.h <span style="color: grey">(68b3e00)</span></li>
<li>src/connection.h <span style="color: grey">(a20d1f7)</span></li>
<li>src/device.h <span style="color: grey">(bca098b)</span></li>
<li>src/dhcp4config.h <span style="color: grey">(35082ba)</span></li>
<li>src/dhcp6config.h <span style="color: grey">(91ca914)</span></li>
<li>src/genericdevice.h <span style="color: grey">(d95fab0)</span></li>
<li>src/generictypes.h <span style="color: grey">(cd45430)</span></li>
<li>src/gredevice.h <span style="color: grey">(eeb682c)</span></li>
<li>src/infinibanddevice.h <span style="color: grey">(c9597cb)</span></li>
<li>src/ipaddress.h <span style="color: grey">(ebc3e5f)</span></li>
<li>src/ipconfig.h <span style="color: grey">(5eb0227)</span></li>
<li>src/iproute.h <span style="color: grey">(13afe15)</span></li>
<li>src/macvlandevice.h <span style="color: grey">(ab02831)</span></li>
<li>src/manager.h <span style="color: grey">(e79b933)</span></li>
<li>src/modemdevice.h <span style="color: grey">(e40d457)</span></li>
<li>src/olpcmeshdevice.h <span style="color: grey">(9af2342)</span></li>
<li>src/secretagent.h <span style="color: grey">(02e4c9a)</span></li>
<li>src/settings.h <span style="color: grey">(f5fe486)</span></li>
<li>src/settings/adslsetting.h <span style="color: grey">(89ab5b5)</span></li>
<li>src/settings/bluetoothsetting.h <span style="color: grey">(9a32851)</span></li>
<li>src/settings/bondsetting.h <span style="color: grey">(f3ae1ec)</span></li>
<li>src/settings/bridgeportsetting.h <span style="color: grey">(7a8f74a)</span></li>
<li>src/settings/bridgesetting.h <span style="color: grey">(4628cf5)</span></li>
<li>src/settings/cdmasetting.h <span style="color: grey">(ecd30da)</span></li>
<li>src/settings/connectionsettings.h <span style="color: grey">(252f8e9)</span></li>
<li>src/settings/genericsetting.h <span style="color: grey">(610568a)</span></li>
<li>src/settings/gsmsetting.h <span style="color: grey">(1a152b2)</span></li>
<li>src/settings/infinibandsetting.h <span style="color: grey">(713e01e)</span></li>
<li>src/settings/ipv4setting.h <span style="color: grey">(bdfcc58)</span></li>
<li>src/settings/ipv6setting.h <span style="color: grey">(7e7ca9e)</span></li>
<li>src/settings/olpcmeshsetting.h <span style="color: grey">(217682d)</span></li>
<li>src/settings/pppoesetting.h <span style="color: grey">(a3c5d79)</span></li>
<li>src/settings/pppsetting.h <span style="color: grey">(4755288)</span></li>
<li>src/settings/security8021xsetting.h <span style="color: grey">(486f1bc)</span></li>
<li>src/settings/serialsetting.h <span style="color: grey">(fa0bf57)</span></li>
<li>src/settings/setting.h <span style="color: grey">(86c6e83)</span></li>
<li>src/settings/teamsetting.h <span style="color: grey">(ba58a5d)</span></li>
<li>src/settings/template.h <span style="color: grey">(4f9f680)</span></li>
<li>src/settings/vlansetting.h <span style="color: grey">(8432eab)</span></li>
<li>src/settings/vpnsetting.h <span style="color: grey">(67aea4e)</span></li>
<li>src/settings/wimaxsetting.h <span style="color: grey">(9fd887a)</span></li>
<li>src/settings/wiredsetting.h <span style="color: grey">(fec6860)</span></li>
<li>src/settings/wirelesssecuritysetting.h <span style="color: grey">(5c9a1da)</span></li>
<li>src/settings/wirelesssetting.h <span style="color: grey">(12eed72)</span></li>
<li>src/teamdevice.h <span style="color: grey">(e42bc81)</span></li>
<li>src/tundevice.h <span style="color: grey">(dd66977)</span></li>
<li>src/utils.h <span style="color: grey">(d091c5e)</span></li>
<li>src/vethdevice.h <span style="color: grey">(c9322d0)</span></li>
<li>src/vlandevice.h <span style="color: grey">(bfe2948)</span></li>
<li>src/vpnconnection.h <span style="color: grey">(acd0d2e)</span></li>
<li>src/vpnplugin.h <span style="color: grey">(3a4f181)</span></li>
<li>src/wimaxdevice.h <span style="color: grey">(fb202fa)</span></li>
<li>src/wimaxnsp.h <span style="color: grey">(c9bd856)</span></li>
<li>src/wireddevice.h <span style="color: grey">(193710c)</span></li>
<li>src/wirelessdevice.h <span style="color: grey">(6137036)</span></li>
<li>src/wirelessnetwork.h <span style="color: grey">(1d5cb7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123401/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>