<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122910/">https://git.reviewboard.kde.org/r/122910/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2015, 2:39 p.m. MDT, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On April 15th, 2015, 2:45 p.m. MDT, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As KMoreTools is going to be part of KNewStuff it should be using KNEWSTUFF_EXPORT not KSERVICE_EXPORT.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The install dir now looks like this: http://wstaw.org/m/2015/04/15/plasma-desktopVd2099.png I wonder if this ok to have a duplicate knewstuff_export.h? Or should the files go into the "kns3/KNS3" subdirectory?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good point, using one knewstuff_export.h file would be ideal indeed.</p></pre>
<br />
<p>- Jeremy</p>
<br />
<p>On April 15th, 2015, 2:24 p.m. MDT, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated April 15, 2015, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here (knewstuff).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Example usages:
- dolphin's SpaceInfoToolsMenu: https://git.reviewboard.kde.org/r/122911/
- kate's project addin: https://git.reviewboard.kde.org/r/122374/
- ksnapshot's SendTo menu: https://git.reviewboard.kde.org/r/123342/ - Note, that here the "Not installed" functionality is not used at all. But this use-case takes advantage of the built-in "Configure menu" feature.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/pics/kmoretools-kate-project-1-all-installed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/pics/kmoretools-kate-project-2-two-not-installed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/pics/kmoretools-kate-project-3-config-dialog-all-installed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3b9a403eb473e0c3760506b2757c71d603b99775)</span></li>
<li>src/kmoretools/kmoretools.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretools.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretools_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/kmoretoolsconfigdialog_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kmoretools/ui/kmoretoolsconfigwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(103c5fc98deaf83288b843cc66a87f2d95ad9dfb)</span></li>
<li>tests/kmoretools/1/a.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/1/b.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/1/c.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/kate.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/kate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstalledapp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstalledapp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/2/mynotinstapp2.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kmoretools/kmoretoolstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122910/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>