<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120393/">https://git.reviewboard.kde.org/r/120393/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On març 18th, 2015, 11:23 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm all for getting rid of the Nepomuk code. However, I'm not too sure about the strigi part. That should still work.</p></pre>
</blockquote>
<p>On març 19th, 2015, 11:31 a.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It does not ;-)
Originally, this review added back the find_package(Strigi) call which was removed a while back (at least before 5.0.0), so this code was/is never compiled.</p></pre>
</blockquote>
<p>On març 23rd, 2015, 3:22 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still cannot give it a ship it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We need to collectively decide if we want to let the Strigi integration be broken and remove the code. Or add the dependency again and see why it doesn't work.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Agreeing with Vishesh here, can you send a new email to kde-core-devel mailing list mentioning what should we do, if stop supporting strigi or not in kdelibs4support? This way we can get a more project wide discussion about it.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On març 18th, 2015, 6:24 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated mar. 18, 2015, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Strigi check has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, and soprano wasn't even ported to Qt5 (afaik), so this was never compiled.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kfilemetainfotest.cpp <span style="color: grey">(c751cdd)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b662893)</span></li>
<li>src/config-kdelibs4support.h.cmake <span style="color: grey">(1af3ee0)</span></li>
<li>src/kio/kfilemetadataconfigurationwidget.cpp <span style="color: grey">(259b205)</span></li>
<li>src/kio/kfilemetadataprovider.cpp <span style="color: grey">(3468546)</span></li>
<li>src/kio/kfilemetadataprovider_p.h <span style="color: grey">(31137b2)</span></li>
<li>src/kio/kfilemetadatawidget.cpp <span style="color: grey">(1edb069)</span></li>
<li>src/kio/kfilemetainfo.cpp <span style="color: grey">(eae1295)</span></li>
<li>src/kio/kfilemetainfoitem.cpp <span style="color: grey">(62f760d)</span></li>
<li>src/kio/kfilemetainfoitem_p.h <span style="color: grey">(8929e46)</span></li>
<li>src/kio/knfotranslator.cpp <span style="color: grey">(8eec6a1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120393/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>