<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122981/">https://git.reviewboard.kde.org/r/122981/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated March 22, 2015, 4:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Unit tests: use setupTest("testLoadShortcutFromGlobalSettings") and check for m_daemonInstalled
- fix typo
Open issue: probably by calling setupTest("testLoadShortcutFromGlobalSettings") now other tests do not work, even when the new test case is not executed anymore.
```
Starting: /home/gregor/dev/kf5/build/frameworks/kglobalaccel/autotests/kglobalshortcuttest
********* Start testing of KGlobalShortcutTest *********
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.8.3 20140627 [gcc-4_8-branch revision 212064])
PASS : KGlobalShortcutTest::initTestCase()
FAIL! : KGlobalShortcutTest::testSetShortcut() Compared lists differ at index 0.
Actual (KGlobalAccel::self()->shortcut(m_actionA)): <null>
Expected (cutA): <null>
Loc: [/home/gregor/dev/kf5/src/frameworks/kglobalaccel/autotests/kglobalshortcuttest.cpp(111)]
FAIL! : KGlobalShortcutTest::testFindActionByKey() Compared values are not the same
Actual (actionId.first().uniqueName()): "Action A:testLoadShortcutFromGlobalSettings"
Expected (actionIdAUniqueName) : "Action A:testFindActionByKey"
Loc: [/home/gregor/dev/kf5/src/frameworks/kglobalaccel/autotests/kglobalshortcuttest.cpp(139)]
PASS : KGlobalShortcutTest::testChangeShortcut()
FAIL! : KGlobalShortcutTest::testStealShortcut() Compared lists differ at index 0.
Actual (KGlobalAccel::self()->shortcut(m_actionA)): <null>
Expected (cutA): <null>
Loc: [/home/gregor/dev/kf5/src/frameworks/kglobalaccel/autotests/kglobalshortcuttest.cpp(200)]
PASS : KGlobalShortcutTest::testSaveRestore()
PASS : KGlobalShortcutTest::testListActions()
PASS : KGlobalShortcutTest::testComponentAssignment()
PASS : KGlobalShortcutTest::testConfigurationActions()
PASS : KGlobalShortcutTest::testNotification()
PASS : KGlobalShortcutTest::testOverrideMainComponentData()
FAIL! : KGlobalShortcutTest::testForgetGlobalShortcut() '!components.contains(componentId)' returned FALSE. ()
Loc: [/home/gregor/dev/kf5/src/frameworks/kglobalaccel/autotests/kglobalshortcuttest.cpp(420)]
PASS : KGlobalShortcutTest::testLoadShortcutFromGlobalSettings()
PASS : KGlobalShortcutTest::cleanupTestCase()
Totals: 10 passed, 4 failed, 0 skipped, 0 blacklisted
********* Finished testing of KGlobalShortcutTest *********
QCoreApplication::postEvent: Unexpected null receiver
*** Exited with return code: 4 ***
```</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In some cases you need to call loadShortcutFromGlobalSettings() in order not to get a an empty list when calling shortcut(). See discussion in https://git.reviewboard.kde.org/r/122249/.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kglobalshortcuttest.h <span style="color: grey">(2a7b40d34875e16345a659fb9764e4f536ad79c6)</span></li>
<li>autotests/kglobalshortcuttest.cpp <span style="color: grey">(169bf92ffbff985cd4381e771c2fcecaff77156b)</span></li>
<li>src/kglobalaccel.h <span style="color: grey">(3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16)</span></li>
<li>src/kglobalaccel.cpp <span style="color: grey">(1b6b3f5cb6d42401d684e6a491d12a6e57248fd1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122981/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>