<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122970/">https://git.reviewboard.kde.org/r/122970/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yep (looks like you posted a followup commit rather than merging the two, and the commit log on reviewboard is outdated, it still talks about V3). But if you make sure to review and clean up the commit, you can commit.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On March 18th, 2015, 1:07 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 18, 2015, 1:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjobwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes source compatibility from https://git.reviewboard.kde.org/r/122926/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It adds a new org.kde.JobViewV3.xml file. The DBus interface name is still JobViewV2 to keep compatibility with apps still using org.kde.JobViewV2.xml.
It also removes generating code from old org.kde.JobView.xml as it is not used anywhere.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">plasma-workspace stable now builds fine
changing V2 -> V3 in CMakeFiles.txt in master branch enable the new setError method.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(c539bdc)</span></li>
<li>src/kuiserverjobtracker.cpp <span style="color: grey">(7f13a4d)</span></li>
<li>src/kuiserverjobtracker_p.h <span style="color: grey">(daf3902)</span></li>
<li>src/org.kde.JobView.xml <span style="color: grey">(f64d232)</span></li>
<li>src/org.kde.JobViewV2.xml <span style="color: grey">(245a5f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122970/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>